Skip to content

Send driver version with HTTP queries - #220

Closed
conradludgate wants to merge 3 commits into
mainfrom
conrad/sql-over-http-client-info
Closed

Send driver version with HTTP queries#220
conradludgate wants to merge 3 commits into
mainfrom
conrad/sql-over-http-client-info

Conversation

@conradludgate

@conradludgate conradludgate commented Aug 17, 2026

Copy link
Copy Markdown

Introduce a package version header with sql-over-http queries.

conradludgate
conradludgate commented Aug 17, 2026
View reviewed changes
Comment thread src/httpQuery.ts Outdated
@conradludgate
conradludgate force-pushed the conrad/sql-over-http-client-info branch from 0d07eb9 to a9f2b24 Compare August 17, 2026 16:13
@conradludgate
conradludgate marked this pull request as ready for review August 24, 2026 15:12
@jawj

jawj commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Yes, seems sensible enough. Worth noting that this sets fallback_application_name for WebSocket queries as well as a header for HTTP ones.

I guess I'll fold this into the slightly bigger changes I'm working on for password-as-function support for WS ands HTTP. Once browser tests are passing (maybe this was just a glitch?).

@jawj
jawj self-requested a review September 24, 2026 09:38
jawj
jawj approved these changes Sep 24, 2026
View reviewed changes

@jawj jawj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests are passing.

@conradludgate

conradludgate commented Sep 24, 2026

Copy link
Copy Markdown
Author

Ah, tests are failing due to Neon-Client-Info not being part of CORS allow list. Let me go back to the drawing board.

@conradludgate

conradludgate commented Sep 24, 2026

Copy link
Copy Markdown
Author

Worth noting that this sets fallback_application_name for WebSocket queries as well as a header for HTTP ones

Yeah, while it's less important to know the websocket driver I think it makes sense to provide the application_name anyway.

@conradludgate
conradludgate force-pushed the conrad/sql-over-http-client-info branch from 1fe2b8c to 7a36cc3 Compare September 24, 2026 12:50
@jawj
jawj marked this pull request as draft September 25, 2026 09:44
@jawj

jawj commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

This feature has been rolled into https://github.com/neondatabase/serverless/tree/http-connection-parameters, so closing.

@jawj jawj closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jawj jawj jawj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@conradludgate @jawj