Repository navigation
Conversation
|
📄 Docs preview for |
dcmcand
force-pushed
the
fix/chart-webhook-issuer
branch
from
November 20, 2026 13:22
90fe2fa to
83ba6b2
Compare
dcmcand
force-pushed
the
fix/chart-webhook-issuer
branch
from
November 20, 2026 13:56
83ba6b2 to
8404703
Compare
…uer by default The webhook serving Certificate hardcoded ClusterIssuer selfsigned-issuer, which neither the chart nor NIC on main creates, so a fresh install left the operator pod in ContainerCreating. Add the chart value operator.webhook.clusterIssuer and default it to nebari-ca-issuer, the internal CA NIC creates in releases that include nebari-infrastructure-core#787. A missing operator.webhook block (values reused from an older release with --reuse-values) renders the same default; an explicitly empty value fails the render. This changes the default for existing installs. The upgrade notes cover keeping selfsigned-issuer, the brief admission failures while the operator reloads the reissued certificate, and what happens when the configured issuer does not exist. The installation guide, quickstart, README and values reference list the new prerequisite, and docs/architecture/contracts.md records the value as a contract.
dcmcand
force-pushed
the
fix/chart-webhook-issuer
branch
from
November 20, 2026 16:10
8404703 to
e2ad1e8
Compare
jbouder
reviewed
Nov 20, 2026
Contributor
There was a problem hiding this comment.
This screenshot looks unrelated to the issuer change. Nothing links to it, and it sits outside docs/src/assets/, so the site never shows it. Please drop it from the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 4: The operator's webhook certificate comes from a configurable issuer
The chart's webhook serving Certificate hardcoded
ClusterIssuerselfsigned-issuer. Neither the chart nor NIC onmaincreates it, so on a fresh NIC cluster the operator pod sits inContainerCreating(found during the live pre-flight for #233). nebari-infrastructure-core#787 gives every NIC cluster an internal CA and documentsnebari-ca-issueras the issuer packs use for in-cluster and webhook certificates.Contracts touched: chart value
operator.webhook.clusterIssuer(new, recorded indocs/architecture/contracts.md). The default changes fromselfsigned-issuertonebari-ca-issuer, which is a breaking default for clusters without that issuer;upgrading.mdxsays how to keep the old one.Depends on: nebari-dev/nebari-infrastructure-core#787 (merge order). Independent of the #173 / #258 stack.
docs/architecture/contracts.mdandAGENTS.mdare also added by #258:AGENTS.mdis identical, andcontracts.mdhas the same header with different entries, so whichever merges second keeps both sets of entries.What changes
values.yaml:operator.webhook.clusterIssuer: nebari-ca-issuer.operator-webhook-cert.yaml:issuerRef.namecomes from the value. A missingoperator.webhookblock (values reused from an older release withhelm upgrade --reuse-values) renders the same default; an explicitly empty value fails the render. The two copies of the default carry keep-in-sync comments.Validation
helm lint charts/nebari-llm-serving/1 chart(s) linted, 0 chart(s) failedissuerRef: {name: "nebari-ca-issuer", kind: ClusterIssuer}--set operator.webhook.clusterIssuer=selfsigned-issuername: "selfsigned-issuer"--set operator.webhook.clusterIssuer=Error: ... operator.webhook.clusterIssuer is required: name an existing cert-manager ClusterIssuer to sign the operator webhook certificateoperator.webhooknebari-ca-issuermainname: selfsigned-issuer->name: "nebari-ca-issuer"npm run buildcomplete (16 pages),npm test31 passedLive, on a fresh NIC Hetzner cluster built from #787's head:
helm upgrade --reuse-valuesfrom a release installed offmainsucceeds and rendersnebari-ca-issuer.nebari-ca-issuer(issuerCN=Nebari root CA (<domain>), SANs the two.svcnames), and cainjector updated the webhookcaBundle. Admission calls failed withx509: certificate signed by unknown authorityfor about 65 s, until the operator reloaded the new certificate from its Secret volume; then admission worked. The upgrade note warns about this window.Ready=False/IncorrectIssuer, its CertificateRequest staysPending, and admission keeps working with the old certificate until it expires.