[FIX] ASR: return an estimate when geometric_median does not converge#107
Merged
sappelhoff merged 2 commits intoJul 10, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 83.13% 83.10% -0.03%
==========================================
Files 25 25
Lines 2817 2818 +1
==========================================
Hits 2342 2342
- Misses 475 476 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
When the Vardi-Zhang iteration hit `max_iter` without meeting the
tolerance, the `while...else` branch only printed a message and the
function fell through to an implicit `return None`, which would break
callers (`asr_calibrate` / `asr_process` reshape the result). Return the
last iterate `y` instead, which is the best estimate available.
Also fix the message wording ("could converge" -> "could not
converge").
38425ba to
4532509
Compare
nbara
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Vardi–Zhang iteration in
geometric_medianreachedmax_iterwithoutmeeting the tolerance, the
while ... elsebranch only printed a message andthe function fell through to an implicit
return None, which breaks callers(
asr_calibrate/asr_processreshape the result). Return the last iterateyinstead, which is the best estimate available.The message wording is also fixed ("could converge" → "could not converge").
Correctness
of
None(verified with a forced single-iteration run).