Repository navigation
Conversation
`cargo clippy -- -D warnings` (as run in CI) fails on the current stable toolchain: - clippy::double_must_use on every #[async_trait] trait method. Fixed in async-trait 0.1.92; bump the requirement and lockfile (adds syn 3 as a build dependency). - clippy::map_or_identity in filter_envelope_headers: use unwrap_or. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo clippy -- -D warnings, as run in CI, fails onmainwith the currentstable toolchain (Rust 1.99):
clippy::double_must_useon every#[async_trait]trait method(
ImapClient,SmtpClient). The lint fires on code generated byasync-trait 0.1.89.
clippy::map_or_identityinsmtp::client::filter_envelope_headers.Change
async-trait0.1.89 → 0.1.92 (Cargo.tomlandCargo.lock), whichgenerates lint-clean code. This adds
syn3 as a build-time dependency; noother packages change.
.map_or((raw, ""), |p| p)→.unwrap_or((raw, "")).No behaviour change.
cargo clippy --all-targets -- -D warningsis clean,and
cargo testpasses.🤖 Generated with Claude Code