Skip to content

Fix #1131, Remove Memory Manager App from Open Source cFS Bundle - #1140

Open
Cameron-Sykes wants to merge 3 commits into
nasa:devfrom
Cameron-Sykes:fix-1131-remove-memory=manager
Open

Cameron-Sykes wants to merge 3 commits into
nasa:devfrom
Cameron-Sykes:fix-1131-remove-memory=manager

Conversation

@Cameron-Sykes

Copy link
Copy Markdown

name: FSW Code Change
about: Flight Software code changes
labels: fsw

Description of Change

Memory Manager should be removed from open source distribution for security reasons.

Linked Issue

Closes #1131

Requirements Impact

  • Requirement ID(s):
  • Requirements updated as necessary
  • Existing requirements are still satisfied by this change

Testing Evidence

TODO

Unit Tests (UT Assert)

TODO

COSMOS Test Suite

TODO

Areas of Expertise Touched

  • ASTRO
  • CI/CD
  • COSMOS
  • Cybersecurity
  • Docker
  • EDS
  • Git
  • PSPs
  • SBN
  • SMP
  • Tables
  • TSN
  • Unit Tests
  • Other

Author Checklist

  • Linked GitHub issue is referenced above
  • Code has been formatted with .clang-format
  • Static analysis workflows ran and passed
  • Unit tests (UT Assert) updated/added to cover code changes
  • Unit test workflows ran and passed
  • COSMOS test suite was run; tests updated/added if relevant changes were made
  • Requirements have been reviewed; updated or confirmed still satisfied (see above)
  • Testing evidence is included above
  • Self-review of the diff completed

Reviewer Checklist

  • Code logic is correct and matches the stated intent
  • Code is readable, maintainable, and follows project conventions (ask your lead if you are unsure of where to find these conventions)
  • .clang-format has been applied
  • Static analysis results reviewed and acceptable
  • The change has been exercised by the unit tests (not just that tests pass — the new/changed code paths are actually covered)
  • COSMOS test suite was executed against this change and results reviewed (or confirmed N/A with justification)
  • Reviewer has independently verified the change behaves as described (e.g., by running the tests locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted)
  • Memory safety reviewed (allocation, bounds, lifetime, stack usage)
  • Requirements impact reviewed and appropriate
  • Error handling is appropriate
  • Appropriate Expert areas have been reviewed

Reviewer Testing Notes

@Cameron-Sykes Cameron-Sykes self-assigned this Sep 24, 2026
@Cameron-Sykes

Copy link
Copy Markdown
Author

I used cfh to highlight any instances of MM and MM does not appear in the start up process:
image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Memory Manager App from Open Source cFS Bundle

1 participant