Preserve MsPASS time and state through ObsPy decorators - #987
Open
wangyinz wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 68.35% 68.43% +0.08%
==========================================
Files 173 173
Lines 34397 34526 +129
Branches 2474 2474
==========================================
+ Hits 23511 23629 +118
- Misses 10002 10013 +11
Partials 884 884 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:05
wangyinz
marked this pull request as ready for review
August 14, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #864
Summary
Nonewithout invoking the wrapped ObsPy callableRenewed scientific/API review
The first version deleted the four decorators' existing
is_input_deadguards, forced dead copies live, and ran arbitrary ObsPy operations on data that MsPASS had explicitly marked unusable. That was unrelated to the copy-back defect and could change samples/metadata before merely restoring the dead flag. Commite89f4332restores the original zero-call dead/all-dead boundary while keeping the state, relative-time, and atomic ensemble copy-back fixes.Verification
41 passed75 passedpy_compile, andgit diff --check: passedThis PR intentionally remains draft pending human API/scientific review.