Repair the public CSS arrival interval matcher - #975
Open
wangyinz wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 68.35% 68.65% +0.30%
==========================================
Files 173 173
Lines 34397 34402 +5
Branches 2474 2474
==========================================
+ Hits 23511 23620 +109
+ Misses 10002 9898 -104
Partials 884 884 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:03
wangyinz
marked this pull request as ready for review
August 14, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #832
Repairs the public CSS arrival interval matcher contracts, including inclusive MongoDB bounds, deterministic nearest-arrival selection, collection configuration, and error logging. Adds focused real-Mongo regression coverage for boundary, multi-match, missing-field, and custom-collection behavior.
Renewed resource-lifecycle review
The first version materialized a PyMongo cursor for multi-match selection but returned or raised without closing it; its list-based test double hid that leak. Commit
a38586ddwraps the complete multi-match selection intry/finally, closes the cursor on success and failure, and adds a real cursor-like test double that proves both paths. It does not change the arrival-selection formula or error policy.Validation: focused contract
14 passed, 1 skipped(the only skip was the absent local MongoDB service); Black 26.5.1, Python 3.12/3.13py_compile, andgit diff --checkpassed.This PR intentionally remains draft pending human data/API review.