add regex testing for non-alpha characters - #4500
Open
baha-bouali wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4497
[a-zA-z]in the term-matching regex is a typo: the range runs fromA(65)to
z(122), so it also covers the six characters that sit between the twoalphabets, which are
[,\,],^,_and`. And terms were matched acrossthem as if they were letters.
example
fooand the source stringfoo_bar text:\bfoo[a-zA-z]*\bmatchesfoo_bar, highlighting the wholeidentifier as the term
\bfoo[a-zA-Z]*\bdoes not match. In fact,_is a word character, so thereis no word boundary after
fooFor the other five characters the old pattern didn't invent a match, it just
made an existing one too long:
foo[bar]highlightedfoo[barinstead offoo.The old suffix matching on actual letters is the same, so
add-onstill highlightsAdd-Ons.Tests
Added regression coverage for all non-alpha characters in
Highlight.test.jsx,I split them into two because the two groups behave differently:
_is word character no mark at all, while the five non-word characters yieldexactly one mark equal to the term. Both cases fail against the old pattern.
make test-translateran successfully after changes.