Conversation
Because:
- Firefox iOS cannot finish a pairing started from a native-camera scan,
so the hand-off card is only a tap in front of a roadblock
- "Continue in Firefox" reads as progress, which makes the dead end worse
This commit:
- adds a `pairing.ios_handoff` setting, off by default
- plans no iOS hand-off while it is off, so /pair falls through to
/pair/unsupported
- keeps the Android hand-off, where updating Firefox makes a re-scan work
- covers the iOS redirect in the Pair unit tests and the unsupported spec
- names the new flag in the iOS v2 pairing spec and its guide
Closes: FXA-14467
dschom
marked this pull request as ready for review
September 4, 2026 20:04
Because:
- the React pair/unsupported page dropped the `pair-unsupported-header`
id on the system-camera branch, which the Backbone template carries
- the new iOS pairing functional test keys off that id, and failed on it
This commit:
- renders that heading directly with the id, in place of CardHeader
- asserts the id in the Unsupported page tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
pairing.ios_handoffsetting (PAIRING_IOS_HANDOFF), defaultfalse, surfaced asconfig.pairing.iosHandoff.planPairingHandoffplans no hand-off for a non-Firefox iOS browser while the setting is off, so/pairfalls through to/pair/unsupportedwith the scanned hash intact.Pair/IndexandplanPairingHandoffunit tests, and adds an iPhone-UA case topairingUnsupported.spec.ts.Pair/Indexhand-off describe, which sits outside the block that already did.pairingFlowV2iOS.spec.tsandtests/pairing/CLAUDE.md.Issue that this pull request solves
Closes: FXA-14467
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-settings/src/lib/pairing/handoff.tsfor the gate;packages/fxa-settings/src/pages/Pair/Index/index.tsxfor the fall-through to/pair/unsupported./pairpage → config plumbing → tests./pairmount effect has several ordering-sensitive branches; the iOS case now reaches the existing!isFirefoxDesktopbranch rather than returning early.Screenshots (Optional)
N/A — no component markup changed; iOS now lands on the existing
/pair/unsupportedscreen instead of the existing hand-off card.Other information (Optional)
PAIRING_IOS_HANDOFF=trueto re-enable it once Firefox iOS can finish a pairing started from a native-camera scan.pairingFlowV2iOS.spec.ts's hand-off delivery reads the CTA off the rendered page, so that spec now needsPAIRING_IOS_HANDOFF=trueon the stack. Documented in the spec header andtests/pairing/CLAUDE.md.pairingUnsupported.spec.tscase cannot pass against a stack serving pre-fix code, so it was verified by the unit tests locally rather than against a running local stack.