bug(settings): Make the mobile card span the viewport - #21145
Open
dschom wants to merge 1 commit into
Open
Conversation
Because:
* The location/IP container on the Supplicant "One last step to
sync" screen renders narrower than spec on Android.
* AppLayout's main and section are shrink-to-fit, so `.card`'s own
`w-full` never takes effect below the mobileLandscape breakpoint.
This commit:
* Spans main and section to the viewport below `mobileLandscape`,
keeping shrink-to-fit above it so the fixed-width card stays
centered.
* Updates the AppLayout snapshot for the new `main` class list.
Closes #FXA-14460
dschom
marked this pull request as ready for review
September 4, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
AppLayoutgives<main>and<section>no width, so they shrink to fit their content and.card's ownw-fullnever applies belowmobileLandscape. No page-local change can widen a child past its card.This pull request
<main>and<section>to the viewport belowmobileLandscape, leaving shrink-to-fit in place above it.AppLayoutsnapshot for the newmainclass list.Issue that this pull request solves
Closes: FXA-14460
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Other information (Optional)
AppLayoutis shared, so this affects every non-split page below the 480pxmobileLandscapebreakpoint. Only cards whose content is narrower than the viewport change — measured geometry is identical at 480px and above.