Conversation
Because: - Figma puts the mobile pairing screens on white; they render light grey. - `.card` only gains a white background from `mobileLandscape` up, so on a phone the card is transparent and the grey `body` is the whole screen. This commit: - Adds an opt-in `whiteBackground` prop to `AppLayout` that whitens the page wrapper, leaving the default and dark mode untouched. - Passes it from the six `Pair2/Supplicant` screens. The desktop `Authority` screens keep the grey page, which their white cards need for contrast. - Covers the prop in the `AppLayout` suite and the page colour in each supplicant suite. Fixes FXA-14461
dschom
marked this pull request as ready for review
September 4, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Storybook render them light grey.
.cardonly gains a white background frommobileLandscapeup, so on a phonethe card is transparent and the grey
bodyfills the screen.This pull request
whiteBackgroundprop toAppLayoutthat whitens the pagewrapper, leaving the default and dark mode untouched.
Pair2/Supplicantscreens.AppLayoutsuite and the page colour in eachsupplicant suite.
Issue that this pull request solves
Closes: FXA-14461
Checklist
Put an
xin the boxes that applyHow to review (Optional)
AppLayout/index.tsx; the rest is one prop per screen plus its test.AppLayoutfirst, then any one supplicant screen.whiteBackgrounddefaults tofalse, so every other caller is unchanged.Screenshots (Optional)
Other information (Optional)
screens, since leaving four grey would swap one inconsistency for a worse one.
Authorityscreens keep the grey page — their white cards need itfor contrast — so this is supplicant-only.