[Blue fallback] Set config with sig - #1144
Conversation
Signed-off-by: PA <50184410+peyha@users.noreply.github.com>
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
…nto set-config-with-sig-on-mindebt # Conflicts: # src/periphery/README.md # test/BlueFallbackRollingTest.sol
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b687945e5c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Midnight. Configurations set by signature are revoked like any other, with | ||
| `setConfig(..., false)`. |
There was a problem hiding this comment.
This revocation guidance is only true after the signature has already been relayed. If a user signs an enabled=true config and then tries to cancel it with setConfig(..., false) before relay, the user nonce has not advanced, so anyone holding the signature can still submit it before the deadline and turn the config back on. Either add nonce cancellation/bump the nonce on direct revocation, or document that pending signatures remain valid until expiry or nonce consumption.
Useful? React with 👍 / 👎.
| ); | ||
| } | ||
|
|
||
| function setConfigWithSig(RollingSigConfig memory signedStruct, Signature memory signature) external override { |
There was a problem hiding this comment.
| function setConfigWithSig(RollingSigConfig memory signedStruct, Signature memory signature) external override { | |
| function setConfigWithSig(RollingSigConfig memory rollingSigConfig, Signature memory signature) external override { |
4 participants
Requested by peyha · Slack thread
Implements #1142's
setConfigWithSigon top of #1141, extending the signedConfigAuthorizationwithminRollableAssets.Generated by Claude Code