Repository navigation
perf(native): query retained export table facts - #6907
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
[Medium impact] The reviewed changes appear safe to merge. SummaryAdds summary delivery and retained PE/ELF export queries shared by CLI and MCP.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[PE or ELF file] --> B[Complete Evidence]
B --> C[Retained parent]
C --> D[Summary]
C --> E[Selected export or issue page]
C --> F[Complete Evidence bundle]
Reviews (3) · Last reviewed commit: "test(native): verify sparse export view ..." · Reviewed by Greptile |
|
@codex review The follow-up fixes a field-selection bug found during local review: Zod The performance report was regenerated from twelve fresh alternating tasks against main Initial CI run 40015745440 had 57 actual failed cases across source and all eight built shard logs, including cancelled shards. All 57 reproduced with identical full failure messages on that exact main base and the corrected implementation after checkout-path normalization only. The wider control selection and its four passing cases are reported separately. This does not classify any later CI failure without inspection. The requesting user has explicitly authorized proceeding to ready and merge without repeated human confirmation, including waiving those local confirmation requirements. Human-review attestations remain unchecked because no human final-diff review is asserted here. |
|
@codex review |
|
Final-head integration qualification for
The measured workflow, twelve task receipts, oracle and resource/token limitations remain in the committed report. Exact current bindings and local raw receipts are retained under |
|
Integrating tested head Greptile completed successfully on this exact head and all review threads are resolved. The valid sparse-default/digest finding is fixed and covered through actual MCP. CI's build/static/docs/reverse-tool quality, native package baseline and selected real-format lanes passed. Every observed portable failure in run 40020366436 is reproduced on its actual main parent and CI merge with identical full failure messages; four never-started shards are explicitly unexecuted. The aggregate failures are downstream of those same source/shard failures. The author-declaration gate remains a documented, user-waived confirmation requirement; unchecked human-review attestations are not represented as completed human review. The additional Codex refresh is still pending and is not counted as a completed review. Its eventual actionable findings will be followed up. Post-merge verification will exercise the actual merged main with the real LLVM/libc stdio tasks and CLI/offline Evidence workflow. |
|
Post-merge verification passed on actual main |
Summary
Fixes #6900. Native export questions can request a summary and select retained PE/ELF export facts by exact names, original indices, fields and pages. Complete output remains the default and the complete parent Evidence stays accessible.
Problem and expected behavior
libLLVM has 44,459 exports: asking for two names previously delivered the whole table, exceeding the default 10 MiB MCP budget. The new summary plus retained pages succeeds at that budget, preserves every matching version/alias and distinguishes page coverage from incomplete source coverage.
Change and scope
One domain projector serves CLI and MCP. It validates an exact immutable retained report once with a weak lifetime; it does not cache filesystem results. Unfiltered pages slice existing order; filtered queries scan retained rows. Source count validation belongs to the report contract. Projection schemas preserve omitted fields rather than filling historical source defaults; a failing regression and actual MCP checks cover this. Scope decision: not applicable; this extends static file inspection within existing authority.
Contract and boundary impact
Semantic owner: native export contracts and shared analysis-view projector; adapters only deliver Evidence.
CLI/catalog: additive
detail: summaryandnative-exportsexports/issues views; CLI summary requires--evidence_output.Compatibility: existing PE/ELF parsing and complete defaults remain; source indices identify rows within their complete parent, including ordinal-only and forwarded PE exports.
Evidence/provenance: stable complete parent ID, exact name encoding facts, source coverage, partial/unknown explanations and complete bundle access.
Authority/cleanup: static reads, existing session retention and CLI Evidence writes; no target execution or new provider authority.
Generated metadata: contracts and authored skill reference updated; ignored catalogs/packaged skills regenerated and checked locally, not committed.
Read existing files or captured data.
Launch or attach to a process. Validation launches CLI/MCP helper processes only.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration. Explicit Evidence output files only.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.
Evidence and regression coverage
Independent GNU readelf plus directly mapped ELF version bytes verified real LLVM/libc answers, full counts and unchanged artifact bytes. Three alternating complete/selected task pairs per artifact had identical answers, parent IDs and complete source report digests. Reproduction, full ranges and receipts.
Token estimates include all 220 input tool definitions, arguments and text replies once (
cl100k_base); no actual model ran. LLVM comparison used 64 MiB for both lanes; separate default 10 MiB probes observed baseline refusal and selected success. Fresh servers, OS caches unflushed, 100% aggregate CPU quota, 3 GiB early stop/4 GiB hard/no swap. All twelve tasks passed with verified payload cleanup and no resource stops/OOM. No parser speedup or universal latency improvement is claimed; libc pays extra calls with no established latency gain. Real PE performance is unmeasured.Validation performed
npm run test:focused -- src/native/exports/NativeExportsView.test.ts src/native/exports/NativeExportParser.test.ts tests/acceptance/applications/nativeExportsViews.test.ts tests/boundary/mcp/binaryDiagnosticsMcp.test.ts— 48 passed, including actual CLI/stdio transport, advertised schema validation, exact sparse columns and recomputed returned view digests.npm run check— passed, repeated after adding measurement reports.npm run docs:check— passed, repeated after reporting changes; nine README conformance tests passed.npm run verify:test-discovery— all 2,180 tests discovered exactly once.c7a90b742a29328e5b0069c6f8a34381e0c11e57, baseline mainf713087132021d235682f908a1c0f3bc6ab8762d. Later reporting commit changes no production code.Initial CI run 40015745440: static/build/docs and selected real-format qualifications passed. All eight shard logs were inspected, including cancelled jobs: 11 source + 46 built failures were actually observed. Controls against that exact main base and current implementation reproduced all 57 with identical case identities and full failure messages, normalizing only the two checkout paths (including their shared dependency realpath). The broader selection executed 11 source cases (11 failed) and 52 built cases (48 failed, four passed) on both; extra selected cases are not claimed as CI observations. The report preserves scope and receipt references. Later CI runs are evaluated separately.
Compatibility, safety, and release
Additive API, no migration or dependency changes. PE/ELF fixture coverage includes aliases, ordinal-only/forwarded exports, versions, encoding, partial/unsupported empty pages, malformed imports and historical omissions. Real Linux ELF workflows qualified; no real Hopper/Ghidra/IDA or Windows/PE performance qualification. No target execution, byte mutation or installation changes.
Author readiness
Human owner: requesting user; GitHub identity not separately asserted.
The requesting user explicitly authorized continuing to ready/merge and waiving per-PR human confirmation in this maintenance session. The declarations below remain unchecked because this record does not attest that a human reviewed the final diff.
Before merge
type(scope): outcome.