Repository navigation
fix(native): preserve unknown ELF export coverage without a dynsym section - #6827
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no actionable issue was found in the changed code. SummaryThe shared ELF reader now records whether the file declares
Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Latest head The Source tests job in CI 40007458412 reports 11 failures: five Map-operation cases, one shared callable-alias case, four Frida cleanup cases, and one bundle-resource schema case. I reproduced those exact 11 cases against CI base The eight built test shards remain active. Their results and any partial reports/canceled logs will be audited before merge; this source attribution does not establish that every remaining CI failure is unrelated. |
|
Final audit of CI 40007458412 on exact head
|
|
Post-merge verification passed on actual main |
Closes #6792.
ELF images with
PT_DYNAMICbut noSHT_DYNSYMsection incorrectly reported a complete, empty export inventory. The shared ELF directory reader now owns the dynamic-segment observation; CLI/MCP reportunsupportedwith a reason. Existing symbol-table results remain intact. Read-only format correction; no new execution authority or public schema.Validation on the current main integration:
npm run check, test discovery, and 166 selected Linux tests pass, including actual CLI/stdio MCP cases and PE/IL2CPP/GPU/Rust reader consumers. Original author validation: 113 tests on macOS, including regressions that failed before the fix; test discovery passed.PT_DYNAMICdeclarations and selected symbol bytes; originalreadelfagrees. The reduced files are not loaded or executed;readelf -Ditself cannot enumerate these reduced layouts, and that failed oracle attempt is retained.Codex review completed with no findings. CI failed: all 61 observed failures (including 47 omitted from the aggregate report by canceled shards) reproduce with identical complete failure diagnostics on the exact CI base and merge trees. Baseline-only bypass is explicitly authorized for this maintenance session; canceled/skipped coverage remains unverified. See the final CI attribution comment. The original author's readiness declaration below is preserved.
Author readiness
Human owner: @leeguooooo