Fix DomNodeInserted Deprecation - #22
Closed
PelledeGreeuw wants to merge 2 commits into
Closed
Conversation
Owner
|
Thanks for tackling this! While testing, I found this approach doesn't fully fix #16: observing I've opened #24 with a I'll go ahead and close this in favor of #24 — happy to revisit if I've misjudged something here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DomNodeInserted Deprecation
Purpose
The MutationEvent API has been deprecated (#21) and some browsers already dropped support completely MDN. This causes a warning in the developer console and prevents flatpickrs which are inserted through e.g. a modal (#16 ) from being initialized.
Approach
Removed the DOMNodeInserted event listener and replaced it with a MutationObserver
Issues solved in this PR
What has Changed