cache: keep a referenced equalImmutable on release - #7156
Draft
mmiller-sh wants to merge 1 commit into
Draft
mmiller-sh wants to merge 1 commit into
mmiller-sh wants to merge 1 commit into
Conversation
Releasing a mutable also removes its equalImmutable. finalize clears the immutable's equalMutable but leaves mutable.equalImmutable pointing back at it, so an immutable that has since become another record's parent is removed while that record still lists it. The child is then stranded on a parent the manager no longer holds, and DiskUsage dies dereferencing it. Only remove the equalImmutable when nothing else references it, matching the check GetMutable already makes. Signed-off-by: Matt Miller <matt@mattmiller.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing a mutable also removes its equalImmutable. finalize clears the immutable's equalMutable but leaves mutable.equalImmutable pointing back at it, so an immutable that has since become another record's parent is removed while that record still lists it. The child is then stranded on a parent the manager no longer holds, and DiskUsage dies dereferencing it.
Only remove the equalImmutable when nothing else references it, matching the check GetMutable already makes.