Revise native oembed_controller.js to handle Kaltura embeds - #88
Draft
rshiggin wants to merge 3 commits into
Draft
Revise native oembed_controller.js to handle Kaltura embeds#88rshiggin wants to merge 3 commits into
rshiggin wants to merge 3 commits into
Conversation
Member
Author
|
Refactored version
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video test at
umich-bhl-2014150_aspace_fbc9fce65eb1ba6a7a6d36f8f87e5af2photos: test at
umich-bhl-2014150_aspace_ae081e4d43378a0d3a58103dc1def725Inserts an iframe (div→iframe), which handles CORS by delegating loading/rendering to the browser as an isolated embedded document, rather than having your script read a cross-origin response. The browser loads Kaltura's player in its own separate origin context.
UPDATE: This PR also adds spacing and a light bar between each metadata section on class
.al-show-sub-heading(e.g., Online Content, Using These Materials).