Repository navigation
Clarify all-sequence policy training for Qwen3.5 GRPO - #597
Merged
ShriyaRishab merged 3 commits intoSep 30, 2026
Merged
ShriyaRishab merged 3 commits into
ShriyaRishab merged 3 commits into
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…b_grpo_zero_advantage_filtering # Conflicts: # training_rules.adoc
|
Thanks! Checking with team and see if any questions on this update. |
ShriyaRishab
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpo.use_dynamic_sampling = falseretains zero-reward-variance groups rather than discarding and replacing them.Clarification of existing rules
This change makes explicit the intended scope of the existing Qwen3.5 GRPO requirements—
use_dynamic_sampling = false, a fixed 16 generations per prompt, and the reference GRPO training method—by requiring every otherwise eligible generated sequence to remain in the policy-training computation, including when its advantage or TIS-masked loss contribution is zero. It does not change the permitted masking of gradient contributions by the reference loss.Permitted advantage or importance-sampling masks may reduce a sequence's gradient contribution to zero, but they may not be used to remove the sequence before policy training or reduce the number of sequences presented to the policy-training computation.
Rationale
Predictable zero-contribution sequences must not be exploited to reduce measured training work. In particular, the frequency of zero-advantage groups is an artifact of the benchmark's fixed dataset and limited rollout count and does not reflect typical training conditions.
Scope
This change is intentionally separate from #596, which covers Qwen3.5 GRPO offline evaluation. If #596 merges first, this branch will be rebased so that both rules share one benchmark-specific appendix entry.
Validation
git diff --check