Skip to content

Update opt_learning_rate_warmup_steps and opt_learning_rate_decay_steps constraint check for llama 3.1 8b and 405b model - #435

Merged
ShriyaRishab merged 5 commits into
mlcommons:masterfrom
suachong:master
Sep 23, 2025
Merged

ShriyaRishab merged 5 commits into
mlcommons:masterfrom
suachong:master

Conversation

@suachong

@suachong suachong commented Sep 5, 2025 •

Copy link
Copy Markdown
Contributor

This is a resubmission of PR #434 due to CLA check failed from @gyula-htec

@suachong
suachong requested review from a team as code owners September 5, 2025 15:38
@github-actions

github-actions Bot commented Sep 5, 2025 •

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ShriyaRishab

Copy link
Copy Markdown
Contributor

cc @mmarcinkiewicz

@ShriyaRishab

Copy link
Copy Markdown
Contributor

@suachong - fixed and merged by #436
Can we close this?

@suachong suachong changed the title Remove constraint for opt_learning_rate_decay_steps Updated opt_learning_rate_warmup_steps and opt_learning_rate_decay_steps constraint check for llama 3.1 8b and 405b model Sep 11, 2025
@suachong suachong changed the title Updated opt_learning_rate_warmup_steps and opt_learning_rate_decay_steps constraint check for llama 3.1 8b and 405b model Update opt_learning_rate_warmup_steps and opt_learning_rate_decay_steps constraint check for llama 3.1 8b and 405b model Sep 11, 2025
ShriyaRishab
ShriyaRishab previously approved these changes Sep 23, 2025
@suachong

Copy link
Copy Markdown
Contributor Author

Updated with 1152 factor for 405b @ShriyaRishab

@ShriyaRishab
ShriyaRishab merged commit c5820a7 into mlcommons:master Sep 23, 2025
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants