add a "tie breaker" if all enrollments have no certificate or grade#3599
Open
gumaerc wants to merge 3 commits into
Open
add a "tie breaker" if all enrollments have no certificate or grade#3599gumaerc wants to merge 3 commits into
gumaerc wants to merge 3 commits into
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dashboard’s legacy “displayed enrollment” selection logic to avoid falling back to arbitrary (database-order) enrollments when certificates and grades don’t distinguish between multiple enrollments for the same course. It adds deterministic tie-breaking consistent with the existing getBestRun policy.
Changes:
- Extend
pickDisplayedEnrollmentForLegacyDashboardtie-breaking to prefer an enrollment whose run matchescourse.next_run_id. - Add a further tie-breaker to prefer the enrollment with the later
run.start_date, sorting missing/invalid dates last. - Add unit tests covering both new tie-break scenarios and ensuring selection is order-independent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/model/dashboardViewModel.ts | Adds deterministic tie-breakers (next_run_id, then start_date recency) when cert/grade are tied. |
| frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/model/dashboardViewModel.test.ts | Adds tests verifying the new tie-break behavior and independence from input ordering. |
aa1ac0b to
b732506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/12243
Description (What does it do?)
This PR fixes the above bug by adding another phase of tie breaking to
pickDisplayedEnrollmentForLegacyDashboard. If all enrollments have no grades or certificates, previously the first enrollment in database order would be selected. Instead of database order, we now try the following:next_run_idof the coursestart_dateScreenshots (if appropriate):
How can this be tested?