examples: fix broken examples and unblock their type checks#594
Open
Nelson-PROIA wants to merge 2 commits into
Open
examples: fix broken examples and unblock their type checks#594Nelson-PROIA wants to merge 2 commits into
Nelson-PROIA wants to merge 2 commits into
Conversation
- chat_with_image: dead image URL returned 400; use a live image - structured_outputs: mistral-large-2411 rejected as invalid model; use mistral-large-latest - run_example_scripts.yaml: install the [telemetry] extra so observability examples run - redaction.py: import SpanExporter as the base class so mypy accepts it (valid-type) - pre-commit: add pydantic to the pyright hook deps - guard optional message access in the two examples
andreaonofrei01
self-requested a review
July 20, 2026 09:06
andreaonofrei01
approved these changes
Jul 20, 2026
andreaonofrei01
left a comment
andreaonofrei01
left a comment
Contributor
There was a problem hiding this comment.
lgtm, single question is same as for ts, is the URL for the image stable?
Replace the mistral.ai _astro build asset (per-deploy content hash, would 404 on redeploy) with the Mistral logo pinned to a commit SHA so it can never rot. Addresses review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the examples that fail when run against the API, plus the type-check errors that block them.
async_chat_with_image_no_streaming.py: image URL pointed at a deleted asset (API returned 400 invalid_request_file); use a live image.async_structured_outputs.py:mistral-large-2411is rejected as invalid_model; usemistral-large-latest.run_example_scripts.yaml: install the[telemetry]extra so theobservability/examples run instead of ModuleNotFound.redaction.py: importSpanExporteras the conditional base so mypy accepts it (fixes avalid-typeerror).pydanticto the pyright pre-commit hook deps.Verified: full example suite passes locally (except
skill_lifecycle, which is the AIR-1188 skills-API 500, server-side).