Spelling error, poorly named variable, bloat. - #4
Open
correcthorsebatterystaple-sudo wants to merge 2 commits into
Open
Spelling error, poorly named variable, bloat.#4correcthorsebatterystaple-sudo wants to merge 2 commits into
correcthorsebatterystaple-sudo wants to merge 2 commits into
Conversation
I fixed grammatical / spelling error in a comment. "Too" not "to." I changed a poorly named variable. It's not the time remaining. The time remaining is 25 - the variable. It's the age of the last message. I removed bloat. A string manipulating ternary condition running every time a user is calling moose too often is more than likely exploitable, and absolutely a bad thing in it's own right. ``` NOTE: I haven't tested these changes, and it appears you don't have tests set up in the repo. You should consider that or run whatever ones you have locally. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed grammatical / spelling error in a comment. "Too" not "to."
I changed a poorly named variable. It's not the time remaining. The time remaining is 25 - the variable. It's the age of the last message.
I removed bloat. A string manipulating ternary condition running every time a user is calling moose too often is more than likely exploitable, and absolutely a bad thing in it's own right.
NOTE: I haven't tested these changes, and it appears you don't have tests set up in the repo. You should consider that or run whatever ones you have locally.