[ENG-208] Oauth hardening followups - #413
Merged
Merged
Conversation
…env unconditionally, not only when a turn carries an oauth block
tino097
changed the title
…ar_ds_env dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TurnKeyDataVault._fetch_uncached()now refuses any (engine, name) not in the turn's own connection list, before it ever calls out. Added a standaloneclear_ds_env()inutils/datasources.pyand call it unconditionally at the top ofbuild_cloud_chat_session(), not only insideif request.oauth: restore_namespaced_env()now calls it too instead of duplicating the sweep.