Repository navigation
test: preserve add-field insert errors and retry schema mismatches once - #55228
Open
zhuwenxing wants to merge 1 commit into
Open
zhuwenxing wants to merge 1 commit into
zhuwenxing wants to merge 1 commit into
Conversation
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@zhuwenxing Please associate the related issue to the body of your Pull Request. (eg. "issue: #") |
zhuwenxing
marked this pull request as ready for review
November 6, 2026 07:25
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddFieldChecker discards the insert error after a successful AddCollectionField call and continues to query. Failed inserts can therefore appear as "Unknown error" or be masked by a later query error.
Preserve the exception returned by insert_data. For a typed SchemaMismatchRetryableException, invalidate the schema cache for the client's active database and retry the insert once with regenerated data. Do not repeat the DDL. Return the insert error before querying when the insert still fails; ordinary errors and ambiguous timeouts are not retried.
Validation: