Skip to content

Fix the User-Agent header name sent by mp_ua_header() #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jonas Lejon (jonaslejon) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the User-Agent header name sent by mp_ua_header() #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msticpy/common/utility/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def _get_mp_ua():
@export
def mp_ua_header() -> dict[str, str]:
"""Return headers dict for MSTICPy User Agent."""
return {"UserAgent": _get_mp_ua()}
return {"User-Agent": _get_mp_ua()}


@export
Expand Down
4 changes: 2 additions & 2 deletions msticpy/data/drivers/azure_monitor_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
from ...common.provider_settings import get_protected_setting
from ...common.settings import get_http_proxies, get_http_timeout
from ...common.timespan import TimeSpan
from ...common.utility import export, mp_ua_header
from ...common.utility import MSTICPY_USER_AGENT, export, mp_ua_header
from ...common.wsconfig import WorkspaceConfig
from ..core.query_defns import DataEnvironment
from .driver_base import DriverBase, DriverProps, QuerySource
Expand Down Expand Up @@ -117,7 +117,7 @@ def __init__(self, connection_str: str | None = None, **kwargs):
{"list": self._format_list},
)
self._loaded = True
self._ua_policy = UserAgentPolicy(user_agent=mp_ua_header()["UserAgent"])
self._ua_policy = UserAgentPolicy(user_agent=MSTICPY_USER_AGENT)
self._def_timeout = kwargs.get(
"timeout", kwargs.get("server_timeout", self._DEFAULT_TIMEOUT)
)
Expand Down