fix: clear pre-upgrade observable property shadowing on element upgrade#7647
Draft
AKnassa wants to merge 2 commits into
Draft
fix: clear pre-upgrade observable property shadowing on element upgrade#7647AKnassa wants to merge 2 commits into
AKnassa wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes observable properties that were set on an element before the custom element finished upgrading, so they stay reactive afterwards — notably in Safari.
Why
If a value was assigned to an element before its class definition was applied, that value sat on the instance as a plain property and shadowed the real observable one. The property then looked set but never notified anything of changes.
What changed
Note on the base branch
This targets
fast-element-2.x, notmain. The hydration and element-controller code this fix touches lives only on that line.How to see it
Run the fast-element Playwright suite on
fast-element-2.x. 45 tests cover the element controller.Closes #7194