fix: parse filter elements(...) syntax in f-children directive#7638
Open
Prasad48432 wants to merge 1 commit into
Open
fix: parse filter elements(...) syntax in f-children directive#7638Prasad48432 wants to merge 1 commit into
Prasad48432 wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
@Prasad48432 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR fixes parsing of the
filter elements(...)syntax for the declarativef-childrendirective.Previously,
TemplateParserpassed the entire directive value directly tochildren(), causing expressions such asf-children="{childItems filter elements(li)}"to be treated as a literal property name instead of parsing the filter. As a result, no element filter was applied.This change extracts the filter parsing into a shared helper used by both the
childrenandslotteddirective cases. When afilter elements(...)clause is present, the parser now constructs the appropriate options object and passes it tochildren(), while preserving the existing behavior for directives without filters.🎫 Issues
Closes #7631
👩💻 Reviewer Notes
packages/fast-element/src/declarative/template-parser.ts.filter elements(...)syntax is now shared between thechildrenandslotteddirective implementations to avoid duplicate logic.f-children="{property}"is preserved. The options object is only used when a filter is specified.📑 Test Plan
Added declarative parser tests covering:
f-children="{listItems}"resolves to aChildrenDirectivewith the expected property and no filter.f-children="{childItems filter elements()}"produces a filter that accepts element nodes and rejects text nodes.f-children="{childItems filter elements(li)}"produces a selector-based filter that accepts<li>elements and rejects other elements and text nodes.✅ Checklist
General
$ npm run changeAgents
⏭ Next Steps
npm run changeif required by the maintainers.f-childrenfilter syntax is intended to be part of the public API.