Skip to content

build(client): move "typescript" to catalog - #28175

Open
Jason Hartman (jason-ha) wants to merge 1 commit into
microsoft:mainfrom
jason-ha:build/catalog-TypeScript
Open

build(client): move "typescript" to catalog#28175
Jason Hartman (jason-ha) wants to merge 1 commit into
microsoft:mainfrom
jason-ha:build/catalog-TypeScript

Conversation

@jason-ha

@jason-ha Jason Hartman (jason-ha) commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Add TypeScript catalog for easier workspace wide maintenance and investigations

@jason-ha
build(client): move "typescript" to catalog
56f9370 
Add TypeScript catalog for easier workspace wide maintenance and investigations
Copilot AI lite review requested due to automatic review settings September 3, 2026 22:56
@github-actions github-actions Bot added area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tools area: runtime Runtime related issues area: loader Loader related issues area: driver Driver related issues area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: repo Repo related work dependencies Pull requests that update a dependency file area: website area: dds: sharedstring area: tests Tests to add, test infrastructure improvements, etc area: dds: propertydds area: odsp-driver area: dds: tree labels Sep 3, 2026
@github-actions github-actions Bot added the base: main PRs targeted against main branch label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (669 lines, 166 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI reviewed Sep 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

pnpm-lock.yaml includes */lib.check importer entries that don’t correspond to any project in the repo, indicating the lockfile should be regenerated from a clean workspace (and the new catalog key casing should be reconsidered for consistency).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR centralizes the workspace TypeScript version by introducing a pnpm catalog entry and updating packages to reference it, making repo-wide TypeScript updates and audits easier.

Changes:

  • Add a TypeScript catalog entry in pnpm-workspace.yaml.
  • Update many package.json files to use typescript: "catalog:TypeScript" instead of an inline semver range.
  • Update pnpm-lock.yaml to reflect the catalog usage.
File summaries
File Description
pnpm-workspace.yaml Adds a TypeScript catalog entry.
pnpm-lock.yaml Updates lockfile catalogs/importers to use the TypeScript catalog.
package.json Switches root TypeScript devDependency to the catalog reference.
azure/packages/azure-service-utils/package.json Switches TypeScript devDependency to the catalog reference.
experimental/PropertyDDS/packages/property-changeset/package.json Switches TypeScript devDependency to the catalog reference.
experimental/PropertyDDS/packages/property-common/package.json Switches TypeScript devDependency to the catalog reference.
experimental/PropertyDDS/packages/property-dds/package.json Switches TypeScript devDependency to the catalog reference.
experimental/PropertyDDS/packages/property-properties/package.json Switches TypeScript devDependency to the catalog reference.
experimental/dds/ot/ot/package.json Switches TypeScript devDependency to the catalog reference.
experimental/dds/ot/sharejs/json1/package.json Switches TypeScript devDependency to the catalog reference.
experimental/dds/sequence-deprecated/package.json Switches TypeScript devDependency to the catalog reference.
experimental/dds/tree/package.json Switches TypeScript devDependency to the catalog reference.
experimental/framework/data-objects/package.json Switches TypeScript devDependency to the catalog reference.
experimental/framework/last-edited/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/blobs/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/claims-example/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/collaborative-textarea/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/contact-collection/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/data-object-grid/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/diceroller/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/presence-tracker/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/staging/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/task-selection/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/tree-cli-app/package.json Switches TypeScript devDependency to the catalog reference.
examples/apps/tree-comparison/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/bubblebench/baseline/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/bubblebench/common/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/bubblebench/experimental-tree/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/bubblebench/ot/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/bubblebench/shared-tree/package.json Switches TypeScript devDependency to the catalog reference.
examples/benchmarks/tablebench/package.json Switches TypeScript devDependency to the catalog reference.
examples/client-logger/app-insights-logger/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/canvas/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/clicker/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/codemirror/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/inventory-app/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/monaco/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/constellation-model/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/constellation-view/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/container/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/coordinate-model/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/interface/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/plot-coordinate-view/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/slider-coordinate-view/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/multiview/triangle-view/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/prosemirror/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/smde/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/table-document/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/table-tree/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/text-editor/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/todo/package.json Switches TypeScript devDependency to the catalog reference.
examples/data-objects/webflow/package.json Switches TypeScript devDependency to the catalog reference.
examples/external-data/package.json Switches TypeScript devDependency to the catalog reference.
examples/service-clients/azure-client/external-controller/package.json Switches TypeScript devDependency to the catalog reference.
examples/service-clients/azure-client/todo-list/package.json Switches TypeScript devDependency to the catalog reference.
examples/service-clients/odsp-client/shared-tree-demo/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/bundle-size-tests/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/example-driver/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/example-utils/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/example-webpack-integration/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/import-testing/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/migration-tools/package.json Switches TypeScript devDependency to the catalog reference.
examples/utils/webpack-fluid-loader/package.json Switches TypeScript devDependency to the catalog reference.
examples/version-migration/live-schema-upgrade/package.json Switches TypeScript devDependency to the catalog reference.
examples/version-migration/same-container/package.json Switches TypeScript devDependency to the catalog reference.
examples/version-migration/separate-container/package.json Switches TypeScript devDependency to the catalog reference.
examples/version-migration/tree-shim/package.json Switches TypeScript devDependency to the catalog reference.
examples/view-integration/container-views/package.json Switches TypeScript devDependency to the catalog reference.
examples/view-integration/external-views/package.json Switches TypeScript devDependency to the catalog reference.
examples/view-integration/view-framework-sampler/package.json Switches TypeScript devDependency to the catalog reference.
packages/common/client-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/common/container-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/common/core-interfaces/package.json Switches TypeScript devDependency to the catalog reference.
packages/common/core-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/common/driver-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/cell/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/claims/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/counter/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/ink/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/legacy-dds/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/map/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/matrix/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/merge-tree/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/ordered-collection/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/pact-map/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/register-collection/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/sequence/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/shared-object-base/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/shared-summary-block/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/task-manager/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/test-dds-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/dds/tree/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/debugger/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/driver-base/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/driver-web-cache/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/file-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/local-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/odsp-driver-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/odsp-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/odsp-urlResolver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/replay-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/routerlicious-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/routerlicious-urlResolver/package.json Switches TypeScript devDependency to the catalog reference.
packages/drivers/tinylicious-driver/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/agent-scheduler/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/aqueduct/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/attributor/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/client-logger/app-insights-logger/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/client-logger/fluid-telemetry/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/dds-interceptions/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/fluid-framework/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/fluid-static/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/oldest-client-observer/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/presence-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/presence-runtime/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/presence/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/quill-react/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/react/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/request-handler/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/synthesize/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/tree-agent-langchain/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/tree-agent-ses/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/tree-agent/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/type-factory/package.json Switches TypeScript devDependency to the catalog reference.
packages/framework/undo-redo/package.json Switches TypeScript devDependency to the catalog reference.
packages/loader/container-loader/package.json Switches TypeScript devDependency to the catalog reference.
packages/loader/driver-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/loader/test-loader-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/container-runtime-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/container-runtime/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/datastore-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/datastore/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/id-compressor/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/runtime-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/runtime-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/runtime/test-runtime-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/service-clients/azure-client/package.json Switches TypeScript devDependency to the catalog reference.
packages/service-clients/end-to-end-tests/azure-client/package.json Switches TypeScript devDependency to the catalog reference.
packages/service-clients/end-to-end-tests/odsp-client/package.json Switches TypeScript devDependency to the catalog reference.
packages/service-clients/odsp-client/package.json Switches TypeScript devDependency to the catalog reference.
packages/service-clients/tinylicious-client/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/functional-tests/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/local-server-stress-tests/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/local-server-tests/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/mocha-test-setup/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/snapshots/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/stochastic-test-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-driver-definitions/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-drivers/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-end-to-end-tests/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-pairwise-generator/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-service-load/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/test/test-version-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/changelog-generator-wrapper/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/devtools/devtools-browser-extension/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/devtools/devtools-core/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/devtools/devtools-test-app/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/devtools/devtools-view/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/devtools/devtools/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/fetch-tool/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/fluid-runner/package.json Switches TypeScript devDependency to the catalog reference.
packages/tools/replay-tool/package.json Switches TypeScript devDependency to the catalog reference.
packages/utils/odsp-doclib-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/utils/telemetry-utils/package.json Switches TypeScript devDependency to the catalog reference.
packages/utils/tool-utils/package.json Switches TypeScript devDependency to the catalog reference.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file

Suppressed comments (2)

pnpm-lock.yaml:11442

  • pnpm-lock.yaml contains an importer entry for packages/framework/react/lib.check, but there is no corresponding project in the repo (no lib.check/package.json). This looks like a stale artifact from generating the lockfile with extra local folders present; it should be removed by regenerating the lockfile from a clean checkout.
    pnpm-lock.yaml:16035
  • pnpm-lock.yaml contains an importer entry for packages/tools/devtools/devtools-view/lib.check, but there is no corresponding project in the repo (no lib.check/package.json). This looks like a stale artifact from generating the lockfile with extra local folders present; it should be removed by regenerating the lockfile from a clean checkout.
  • Files reviewed: 165/166 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pnpm-lock.yaml
specifier: catalog:TypeScript
version: 6.0.3

packages/framework/quill-react/lib.check: {}
Comment thread pnpm-workspace.yaml
Comment on lines +51 to +53
# TypeScript
TypeScript:
"typescript": "~6.0.3"
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 253e3ad858341d185338d3a8e02a92a6e6246b54
Head commit: 56f9370d7346887019323b939541a31907f62733

Pending — Build - client packages is running. Results will appear here when the build completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@alexvy86 Alex Villarreal (alexvy86) Awaiting requested review from alexvy86
@MarioJGMsoft MarioJGMsoft Awaiting requested review from MarioJGMsoft

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: repo Repo related work area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc area: tools area: website base: main PRs targeted against main branch dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-ha