Skip to content

tree: Add changeset for transaction minimizer - #28160

Open
alex-pardes wants to merge 2 commits into
microsoft:mainfrom
alex-pardes:add-minimize-changeset
Open

tree: Add changeset for transaction minimizer#28160
alex-pardes wants to merge 2 commits into
microsoft:mainfrom
alex-pardes:add-minimize-changeset

Conversation

@alex-pardes

@alex-pardes alex-pardes commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Added a changeset for the addition of the mimize transaction post-processor, as well as updating a related doc comment.

Copilot AI lite review requested due to automatic review settings September 2, 2026 23:37
@alex-pardes
alex-pardes requested review from a team as code owners September 2, 2026 23:37
@github-actions github-actions Bot added area: tools area: dds Issues related to distributed data structures area: repo Repo related work area: website public api change Changes to a public API area: dds: tree changeset-present base: main PRs targeted against main branch labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (26 lines, 3 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI reviewed Sep 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new/updated docs (changeset + JSDoc) contain a clarity/grammar issue that can mislead readers about the behavioral guarantees.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds release-note coverage for the minimize transaction post-processor and updates its documentation now that the implementation is present (including clarifying a concurrency caveat), with the API report reflecting the deprecation removal.

Changes:

  • Adds a new changeset announcing the minimize transaction post-processor.
  • Updates the minimize doc comment to remove the “no-op” deprecation note and describe behavior/caveats.
  • Updates the generated API report to drop @deprecated from minimize.
File summaries
File Description
packages/dds/tree/src/shared-tree/transactionMinimize.ts Updates minimize JSDoc to reflect current implementation and document concurrency caveat.
packages/dds/tree/api-report/tree.alpha.api.md API report update removing @deprecated on minimize.
.changeset/wicked-teams-go.md Adds a changeset describing minimize and how to use it.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .changeset/wicked-teams-go.md Outdated
Comment on lines +8 to +12
When calling `runTransaction` or `runTransactionAsync`, with `RunTransactionParamsAlpha.postProcessor` set to `minimize`,
edits any newly created nodes which are removed by the transaction will be discarded.
Edits to removed nodes will also be discarded.
This is intended to remove information from changes (which, for example, may have been made by an AI system)
which cannot be easily inspected by a user looking at the effect of that change on the document.
Comment thread packages/dds/tree/src/shared-tree/transactionMinimize.ts
Comment on lines 65 to +69
* out to nothing. Minimizing the change reduces the size of the edit that is
* submitted to (and stored by) the service without altering the observable
* effect of the transaction.
* Minimization may discard edits to nodes which are removed by the transaction,
* which would cause an observable difference if those nodes are reattached by a concurrent edit.

@yann-achard-MS yann-achard-MS Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this does not bother me.

yann-achard-MS
yann-achard-MS reviewed Sep 2, 2026
View reviewed changes
Comment thread .changeset/wicked-teams-go.md Outdated
yann-achard-MS
yann-achard-MS reviewed Sep 3, 2026
View reviewed changes
Comment thread .changeset/wicked-teams-go.md Outdated
@alex-pardes @yann-achard-MS
Apply batched suggestions from code review
654cf02 
Co-authored-by: yann-achard-MS <97201204+yann-achard-MS@users.noreply.github.com>
@alex-pardes
alex-pardes enabled auto-merge (squash) September 3, 2026 00:08
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  340615 links
    2042 destination URLs
    2297 URLs ignored
       0 warnings
       0 errors

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: ed514968ee72bfddc7f59106b19b0f821a3e7078
Head commit: 654cf0289896a4f1bc45e79d342c68b9e510688d

Pending — Build - client packages is running. Results will appear here when the build completes.

dannimad
Daniel Madrid (dannimad) requested changes Sep 3, 2026
View reviewed changes

@dannimad Daniel Madrid (dannimad) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge until 3.0 release is cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dannimad Daniel Madrid (dannimad) dannimad requested changes
@yann-achard-MS yann-achard-MS yann-achard-MS approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

area: dds: tree area: dds Issues related to distributed data structures area: repo Repo related work area: tools area: website base: main PRs targeted against main branch changeset-present public api change Changes to a public API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alex-pardes @yann-achard-MS @dannimad