Remove the TaggedLoggerAdapter compatibility fallback - #28144
Remove the TaggedLoggerAdapter compatibility fallback#28144Mark Fields (markfields) wants to merge 4 commits into
Conversation
Loader 0.45 is outside the current Runtime-to-Loader compatibility window, so remove its untagged logger adapter and document the rolling policy that supersedes the historical fixed LTS. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (209 lines, 6 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
🟢 Approval recommended
The deprecated adapter and runtime fallback are cleanly removed with corresponding test/doc updates and no remaining in-repo references.
Pull request overview
This PR removes the deprecated internal TaggedLoggerAdapter and the container runtime’s legacy fallback that adapted untagged loggers from older (loader 0.45-era) container contexts, aligning runtime↔loader expectations with the documented rolling layer compatibility windows.
Changes:
- Deleted
TaggedLoggerAdapterfrom@fluidframework/telemetry-utilsand removed its internal re-export. - Removed
ContainerRuntimefallback logic that wrappedcontext.loggerwhencontext.taggedLoggerwas absent, now requiringcontext.taggedLogger. - Updated documentation to clarify that tagged logger adaptation is not provided outside the supported layer compatibility window.
File summaries
| File | Description |
|---|---|
| packages/utils/telemetry-utils/src/test/errorLogging.spec.ts | Removes tests that exercised the deleted TaggedLoggerAdapter. |
| packages/utils/telemetry-utils/src/logger.ts | Deletes the deprecated internal TaggedLoggerAdapter implementation. |
| packages/utils/telemetry-utils/src/internal.ts | Stops re-exporting TaggedLoggerAdapter via the internal entrypoint. |
| packages/utils/telemetry-utils/DEV.md | Documents that tagged logger adaptation is not provided outside the layer compatibility window. |
| packages/runtime/container-runtime/src/containerRuntime.ts | Removes old-loader fallback and uses context.taggedLogger directly. |
| LayerCompatibility.md | Clarifies that rolling support windows supersede the older fixed-loader-LTS compatibility policy. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Treat contexts missing both tagged logger support and compatibility details as legacy loaders even while generation zero is inside the calculated window. Preserve the explicit strict-check bypass and verify that legacy untagged loggers never receive runtime telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the generic layer compatibility validation unchanged. Reject legacy loaders explicitly before runtime telemetry is initialized, regardless of the strict compatibility setting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fleet Review — CleanNo issues found across the reviewer fleet for this run. |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Description
Removes the deprecated internal
TaggedLoggerAdapterand the container runtime fallback that adapted untagged loggers from loader 0.45-era container contexts.Supported loaders provide
IContainerContext.taggedLogger. The historical fallback is outside the current 12-month Runtime-to-Loader layer compatibility window, and@internalAPIs carry no stability guarantee. The layer compatibility and telemetry utilities design documentation now clarify these expectations.No customer-facing API reports changed, so this does not require a changeset or API Council review.
Validation:
@fluidframework/container-runtimeand@fluidframework/telemetry-utils@fluidframework/telemetry-utils: 256 tests passed@fluidframework/container-runtime: 975 tests passed, 1 pendingReviewer Guidance
The review process is outlined on this wiki page.
Please verify that the current layer compatibility window is the correct basis for removing the loader 0.45 fallback.