build(server): update ZooKeeper client to 7.3.0 - #28130
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bundle size comparisonBase commit: could not be determined; will be reported when the comparison runs Pending — |
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (259 lines, 4 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Updates Routerlicious’ ZooKeeper client dependency to zookeeper@7.3.0 and refreshes pnpm overrides/lockfile so the workspace resolves the new dependency graph (notably the move away from the deprecated decompress stack toward tar).
Changes:
- Bump
zookeeperdependency/override from^7.2.0to^7.3.0. - Regenerate
pnpm-lock.yamlto reflect the updated ZooKeeper dependency tree (including newtar-related transitive packages). - Add a Routerlicious changeset entry for the dependency update.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/routerlicious/pnpm-workspace.yaml | Updates the workspace override pin for zookeeper to ^7.3.0. |
| server/routerlicious/pnpm-lock.yaml | Updates the lockfile to resolve zookeeper@7.3.0 and its new transitive dependencies. |
| server/routerlicious/packages/services-ordering-zookeeper/package.json | Bumps the direct zookeeper dependency to ^7.3.0. |
| server/routerlicious/.changeset/update-zookeeper-client.md | Adds release-note/changelog entry for the dependency upgrade. |
Files not reviewed (1)
- server/routerlicious/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Update the ZooKeeper client dependency | ||
|
|
||
| The ZooKeeper client dependency has been updated to version 7.3.0, replacing its deprecated archive extraction dependencies with `tar`. |
|
Update: this PR cannot be merged since it has build errors. The reason is that MSFT registry does not have zoo keeper 7.3 yet |
| "@fluidframework/server-services-ordering-zookeeper": minor | ||
| "__section": other | ||
| --- | ||
|
|
There was a problem hiding this comment.
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
Are there any user-facing implications to this update? We generally only create changesets for user-facing changes. If not, you can probably just remove this.
How contribute to this repo.
Guidelines for Pull Requests.
Description
Updates the Routerlicious ZooKeeper client dependency from 7.2.0 to 7.3.0 and refreshes the workspace override and lockfile.
ZooKeeper 7.3.0 replaces its deprecated
decompressdependency stack withtarwithout changing the runtime client API.Reviewer Guidance
The review process is outlined in the pull request guidelines.
The package compiles and passes type compatibility, lint, formatting, and policy checks. The Linux Docker image built the native addon successfully, loaded version 7.3.0, established ZooKeeper sessions, and processed Kafka ordering traffic. The package has no dedicated unit or integration test script; repository CI will run after the PR is opened.