Skip to content

build(server): update ZooKeeper client to 7.3.0 - #28130

Open
yunho-microsoft wants to merge 1 commit into
microsoft:mainfrom
yunho-microsoft:yunho-microsoft-bump-zookeeper-7-3
Open

build(server): update ZooKeeper client to 7.3.0#28130
yunho-microsoft wants to merge 1 commit into
microsoft:mainfrom
yunho-microsoft:yunho-microsoft-bump-zookeeper-7-3

Conversation

@yunho-microsoft

Copy link
Copy Markdown
Contributor

How contribute to this repo.

Guidelines for Pull Requests.

Description

Updates the Routerlicious ZooKeeper client dependency from 7.2.0 to 7.3.0 and refreshes the workspace override and lockfile.

ZooKeeper 7.3.0 replaces its deprecated decompress dependency stack with tar without changing the runtime client API.

Reviewer Guidance

The review process is outlined in the pull request guidelines.

The package compiles and passes type compatibility, lint, formatting, and policy checks. The Linux Docker image built the native addon successfully, loaded version 7.3.0, established ZooKeeper sessions, and processed Kafka ordering traffic. The package has no dedicated unit or integration test script; repository CI will run after the PR is opened.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@yunho-microsoft
yunho-microsoft requested a review from a team as a code owner August 31, 2026 23:00
Copilot AI lite review requested due to automatic review settings August 31, 2026 23:00
@github-actions github-actions Bot added area: server Server related issues (routerlicious) area: tools area: repo Repo related work area: website changeset-present base: main PRs targeted against main branch labels Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: could not be determined; will be reported when the comparison runs
Head commit: 1dca467edff7d3dede610cb92b889a815e3b34fe

Pending — Build - client packages is running. Results will appear here when the build completes.

@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (259 lines, 4 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Routerlicious’ ZooKeeper client dependency to zookeeper@7.3.0 and refreshes pnpm overrides/lockfile so the workspace resolves the new dependency graph (notably the move away from the deprecated decompress stack toward tar).

Changes:

  • Bump zookeeper dependency/override from ^7.2.0 to ^7.3.0.
  • Regenerate pnpm-lock.yaml to reflect the updated ZooKeeper dependency tree (including new tar-related transitive packages).
  • Add a Routerlicious changeset entry for the dependency update.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
server/routerlicious/pnpm-workspace.yaml Updates the workspace override pin for zookeeper to ^7.3.0.
server/routerlicious/pnpm-lock.yaml Updates the lockfile to resolve zookeeper@7.3.0 and its new transitive dependencies.
server/routerlicious/packages/services-ordering-zookeeper/package.json Bumps the direct zookeeper dependency to ^7.3.0.
server/routerlicious/.changeset/update-zookeeper-client.md Adds release-note/changelog entry for the dependency upgrade.
Files not reviewed (1)
  • server/routerlicious/pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +6 to +8
Update the ZooKeeper client dependency

The ZooKeeper client dependency has been updated to version 7.3.0, replacing its deprecated archive extraction dependencies with `tar`.
@yunho-microsoft

Copy link
Copy Markdown
Contributor Author

Update: this PR cannot be merged since it has build errors. The reason is that MSFT registry does not have zoo keeper 7.3 yet

"@fluidframework/server-services-ordering-zookeeper": minor
"__section": other
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -0,0 +1,8 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any user-facing implications to this update? We generally only create changesets for user-facing changes. If not, you can probably just remove this.

@zhangxin511
zhangxin511 self-requested a review September 1, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: repo Repo related work area: server Server related issues (routerlicious) area: tools area: website base: main PRs targeted against main branch changeset-present

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants