Skip to content

Fix CMake generator expression - #30

Merged
David-LP99 merged 1 commit into
kiltedfrom
Narukara-patch-1
Aug 20, 2026
Merged

David-LP99 merged 1 commit into
kiltedfrom
Narukara-patch-1

Conversation

@Narukara

@Narukara Narukara commented Aug 19, 2026 •

Copy link
Copy Markdown

When building the kilted branch of micro-ROS/micro_ros_espidf_component, I get the following error:

--- stderr: rcl
CMake Error at CMakeLists.txt:88 (add_library):
  Target "rcl" links to target
  "$<0:rcl_interfaces::rcl_interfaces__rosidl_generator_c" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at CMakeLists.txt:88 (add_library):
  Target "rcl" links to target
  "rcl_interfaces::rcl_interfaces__rosidl_typesupport_c>" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Generate step failed.  Build files cannot be regenerated correctly.

This appears to be caused by unquoted generator expressions being split at semicolons. This issue only seems to occur with older versions of CMake. I'm using CMake 3.22.1.

Local testing confirms that the project builds successfully after the generator expressions are quoted.

@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@David-LP99
David-LP99 merged commit ec6ff30 into kilted Aug 20, 2026
3 checks passed
@David-LP99

Copy link
Copy Markdown

@mergify backport rolling lyrical

@mergify

mergify Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

backport rolling lyrical

✅ Backports have been created

Details

Cherry-pick of dc07301 has failed:

On branch mergify/bp/rolling/pr-30
Your branch is up to date with 'origin/rolling'.

You are currently cherry-picking commit dc07301.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of dc07301 has failed:

On branch mergify/bp/lyrical/pr-30
Your branch is up to date with 'origin/lyrical'.

You are currently cherry-picking commit dc07301.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

David-LP99 pushed a commit that referenced this pull request Sep 29, 2026
David-LP99 pushed a commit that referenced this pull request Sep 29, 2026
David-LP99 added a commit that referenced this pull request Oct 6, 2026
* micro-ROS changes over dashing
  - Remove security directory (#2)
  - Remove test_security_directory test (#4)
  - Moving allocators init (#5)

* Avoid logging on build time based on RCutils flags (#6)

* Fix remapping (#7)

* Fix disabled logging (#8)

* Release micro-ROS Foxy (#9)
  - Add the RCL_COMMAND_LINE_ENABLED and RCL_LOGGING_ENABLED CMake options, both
    disabled by default
  - Leave the arguments, remapping and logging sources out of the build, along
    with rcl_yaml_param_parser and the logging implementation

* Updates 17092020
  - Guard the arguments check of rcl_node_options_copy()

* Add the micro-ROS fork update checker workflow

* Disable logger name (#11) (#13)

* Avoid uint64_t operation when handling context (#16) (#18)
  - Replace the atomic instance id storage by a plain uint32_t counter
  - Clean the id rollover check to avoid the invalid value instead of failing

* Update fork checker for Humble

* Update fork checker for Rolling

* Iron release (#19) (#20)

* Update micro-ROS conditional compilation
  - Replace both flags by a single RCL_MICROROS option, enabled by default, and
    the inverse RCL_MICROROS_COMPLETE_IMPL public definition
  - Ignore rcl_yaml_param_parser on the micro-ROS build (COLCON_IGNORE)

* Disable get_type_description service (#22)

* Remove type cache register methods (#23)
  - Exclude node_type_cache and the type hash emission from publishers,
    subscriptions, services, clients and action entities
  - Keep type_description_conversions and type_hash out of the build

* Address memory issue of type hash
  - Store the type hash in each entity implementation instead of querying the
    node type cache on finalization

* Fix tracetools
  - Export the tracetools dependency also on micro-ROS builds

* exclude rcl_validate_enclave_name and rcl_get_security_options_from_environment
  from micro-ROS (#24)

* Fix CMake generator expression (#30)

Dropped during the rebase as superseded by upstream:
* Remove security directory (#2)
* Remove test_security_directory test (#4)
* Moving allocators init (#5)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com>
Co-authored-by: acuadros95 <acuadros1995@gmail.com>
Co-authored-by: Antón Casas <antoncasas@eprosima.com>
Co-authored-by: Narukara <narukara17@gmail.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99 added a commit that referenced this pull request Oct 6, 2026
* micro-ROS changes over dashing
  - Remove security directory (#2)
  - Remove test_security_directory test (#4)
  - Moving allocators init (#5)

* Avoid logging on build time based on RCutils flags (#6)

* Fix remapping (#7)

* Fix disabled logging (#8)

* Release micro-ROS Foxy (#9)
  - Add the RCL_COMMAND_LINE_ENABLED and RCL_LOGGING_ENABLED CMake options, both
    disabled by default
  - Leave the arguments, remapping and logging sources out of the build, along
    with rcl_yaml_param_parser and the logging implementation

* Updates 17092020
  - Guard the arguments check of rcl_node_options_copy()

* Add the micro-ROS fork update checker workflow

* Disable logger name (#11) (#13)

* Avoid uint64_t operation when handling context (#16) (#18)
  - Replace the atomic instance id storage by a plain uint32_t counter
  - Clean the id rollover check to avoid the invalid value instead of failing

* Update fork checker for Humble

* Update fork checker for Rolling

* Iron release (#19) (#20)

* Update micro-ROS conditional compilation
  - Replace both flags by a single RCL_MICROROS option, enabled by default, and
    the inverse RCL_MICROROS_COMPLETE_IMPL public definition
  - Ignore rcl_yaml_param_parser on the micro-ROS build (COLCON_IGNORE)

* Disable get_type_description service (#22)

* Remove type cache register methods (#23)
  - Exclude node_type_cache and the type hash emission from publishers,
    subscriptions, services, clients and action entities
  - Keep type_description_conversions and type_hash out of the build

* Address memory issue of type hash
  - Store the type hash in each entity implementation instead of querying the
    node type cache on finalization

* Fix tracetools
  - Export the tracetools dependency also on micro-ROS builds

* exclude rcl_validate_enclave_name and rcl_get_security_options_from_environment
  from micro-ROS (#24)

* Fix CMake generator expression (#30)

Dropped during the rebase as superseded by upstream:
* Remove security directory (#2)
* Remove test_security_directory test (#4)
* Moving allocators init (#5)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com>
Co-authored-by: acuadros95 <acuadros1995@gmail.com>
Co-authored-by: Antón Casas <antoncasas@eprosima.com>
Co-authored-by: Narukara <narukara17@gmail.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants