Repository navigation
Fix CMake generator expression - #30
Merged
Merged
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Amronos
approved these changes
Aug 19, 2026
|
@mergify backport rolling lyrical |
✅ Backports have been createdDetails
Cherry-pick of dc07301 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of dc07301 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This was referenced Aug 20, 2026
David-LP99
pushed a commit
that referenced
this pull request
Sep 29, 2026
David-LP99
pushed a commit
that referenced
this pull request
Sep 29, 2026
David-LP99
added a commit
that referenced
this pull request
Oct 6, 2026
* micro-ROS changes over dashing - Remove security directory (#2) - Remove test_security_directory test (#4) - Moving allocators init (#5) * Avoid logging on build time based on RCutils flags (#6) * Fix remapping (#7) * Fix disabled logging (#8) * Release micro-ROS Foxy (#9) - Add the RCL_COMMAND_LINE_ENABLED and RCL_LOGGING_ENABLED CMake options, both disabled by default - Leave the arguments, remapping and logging sources out of the build, along with rcl_yaml_param_parser and the logging implementation * Updates 17092020 - Guard the arguments check of rcl_node_options_copy() * Add the micro-ROS fork update checker workflow * Disable logger name (#11) (#13) * Avoid uint64_t operation when handling context (#16) (#18) - Replace the atomic instance id storage by a plain uint32_t counter - Clean the id rollover check to avoid the invalid value instead of failing * Update fork checker for Humble * Update fork checker for Rolling * Iron release (#19) (#20) * Update micro-ROS conditional compilation - Replace both flags by a single RCL_MICROROS option, enabled by default, and the inverse RCL_MICROROS_COMPLETE_IMPL public definition - Ignore rcl_yaml_param_parser on the micro-ROS build (COLCON_IGNORE) * Disable get_type_description service (#22) * Remove type cache register methods (#23) - Exclude node_type_cache and the type hash emission from publishers, subscriptions, services, clients and action entities - Keep type_description_conversions and type_hash out of the build * Address memory issue of type hash - Store the type hash in each entity implementation instead of querying the node type cache on finalization * Fix tracetools - Export the tracetools dependency also on micro-ROS builds * exclude rcl_validate_enclave_name and rcl_get_security_options_from_environment from micro-ROS (#24) * Fix CMake generator expression (#30) Dropped during the rebase as superseded by upstream: * Remove security directory (#2) * Remove test_security_directory test (#4) * Moving allocators init (#5) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com> Co-authored-by: acuadros95 <acuadros1995@gmail.com> Co-authored-by: Antón Casas <antoncasas@eprosima.com> Co-authored-by: Narukara <narukara17@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99
added a commit
that referenced
this pull request
Oct 6, 2026
* micro-ROS changes over dashing - Remove security directory (#2) - Remove test_security_directory test (#4) - Moving allocators init (#5) * Avoid logging on build time based on RCutils flags (#6) * Fix remapping (#7) * Fix disabled logging (#8) * Release micro-ROS Foxy (#9) - Add the RCL_COMMAND_LINE_ENABLED and RCL_LOGGING_ENABLED CMake options, both disabled by default - Leave the arguments, remapping and logging sources out of the build, along with rcl_yaml_param_parser and the logging implementation * Updates 17092020 - Guard the arguments check of rcl_node_options_copy() * Add the micro-ROS fork update checker workflow * Disable logger name (#11) (#13) * Avoid uint64_t operation when handling context (#16) (#18) - Replace the atomic instance id storage by a plain uint32_t counter - Clean the id rollover check to avoid the invalid value instead of failing * Update fork checker for Humble * Update fork checker for Rolling * Iron release (#19) (#20) * Update micro-ROS conditional compilation - Replace both flags by a single RCL_MICROROS option, enabled by default, and the inverse RCL_MICROROS_COMPLETE_IMPL public definition - Ignore rcl_yaml_param_parser on the micro-ROS build (COLCON_IGNORE) * Disable get_type_description service (#22) * Remove type cache register methods (#23) - Exclude node_type_cache and the type hash emission from publishers, subscriptions, services, clients and action entities - Keep type_description_conversions and type_hash out of the build * Address memory issue of type hash - Store the type hash in each entity implementation instead of querying the node type cache on finalization * Fix tracetools - Export the tracetools dependency also on micro-ROS builds * exclude rcl_validate_enclave_name and rcl_get_security_options_from_environment from micro-ROS (#24) * Fix CMake generator expression (#30) Dropped during the rebase as superseded by upstream: * Remove security directory (#2) * Remove test_security_directory test (#4) * Moving allocators init (#5) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com> Co-authored-by: acuadros95 <acuadros1995@gmail.com> Co-authored-by: Antón Casas <antoncasas@eprosima.com> Co-authored-by: Narukara <narukara17@gmail.com> Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the kilted branch of micro-ROS/micro_ros_espidf_component, I get the following error:
This appears to be caused by unquoted generator expressions being split at semicolons. This issue only seems to occur with older versions of CMake. I'm using CMake 3.22.1.
Local testing confirms that the project builds successfully after the generator expressions are quoted.