Repository navigation
1.27.0: camera popup look, button style, video media_height (#42, #43, #44) - #45
Merged
Merged
Conversation
Camera and video_url popups never passed media_height to the app, so the poster box took the snapshot's pixel size, wrong for anamorphic NVR stills. A per-call media_height is now sent as media.video.height; the per-device default is not, so existing popups keep their current sizing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
button_color, button_focus_color, button_text_color, button_border_color and button_corner_radius pass straight through as the app's buttonColor/... props. Each is sent only when set, so unstyled popups are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New pipup.show fields for the app's camera popup options, each sent only when set: - live_badge, live_badge_color, live_badge_position - media_full_bleed - buttons_inline services.yaml, strings, en and nl included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # custom_components/pipup/const.py # custom_components/pipup/services.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates @pelkiegr's #42, #43 and #44 for 1.27.0 (app side: PiPup #72 / 0.28.0), with their commits kept through merge commits.
const.pyandservices.py; both sides are kept.app >= 0.28.0. README section, CHANGELOG, version 1.27.0.services.yamlchecked for duplicate keys (51 fields); the three translation files load. Tests: 48/48 locally.Closes #42, closes #43, closes #44.
🤖 Generated with Claude Code