Skip to content

Temporary fix for broadcom interface naming schema #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iljarotar wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Temporary fix for broadcom interface naming schema #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
404b48e
Temporary fix for broadcom interface naming schema
iljarotar Aug 3, 2026
a42e98b
checkout this branch
iljarotar Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
name: Docker Build Action
on:
pull_request:
branches:
- master
# pull_request:
# branches:
# - master
release:
types:
- published
push:
branches:
- master
- temporary-fix-for-broadcom-interface-naming

env:
REGISTRY: ghcr.io
Expand Down
4 changes: 2 additions & 2 deletions cmd/internal/switcher/sonic/sonic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ func (s *Sonic) GetNics(ctx context.Context, log *slog.Logger, blacklist []strin
return nil, fmt.Errorf("failed to get ports config")
}

for name, portConfig := range ports {
for name := range ports {
if slices.Contains(blacklist, name) {
log.Debug("skip interface, because it is contained in the blacklist", "interface", name, "blacklist", blacklist)
continue
}

nic := &models.V1SwitchNic{
Identifier: &portConfig.Alias,
Identifier: &name,
Name: &name,
}
nics = append(nics, nic)
Expand Down
Loading