Repository navigation
Conversation
The Docker workflow installs the published metassr CLI pinned to npm/cli/package.json (currently 1.0.0-alpha.2), but #249 added /dist internals assertions that require the server fix merged in the same PR. alpha.2 still serves server bundles, cache and the manifest under /dist, so four SSR assertions fail and the SSG block would fail the same way once reached, breaking Docker CI on master since #249. Gate both blocks behind METASSR_DIST_INTERNALS_SINCE (default 1.0.0-alpha.3), matching the version gating already used for per-request rendering and TypeScript API routes. Source builds (METASSR_VERSION unset) always enforce the assertions.
fahdfady
marked this pull request as draft
November 16, 2026 23:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Docker CI has failed on every master push since #249 (
9f8f445):43975042067(fix: detect route shape collisions for API and page routes #254)43970972080(feat: pass dynamic route params to pages and API handlers #243)43684849967(fix(server): keep dist internals private #249)The Docker workflow installs the published CLI pinned to
npm/cli/package.json(1.0.0-alpha.2,.github/workflows/docker.yml:31-32),but #249 added
/distinternals assertions inssr.sh/ssg.shthat requirethe server fix merged in that same PR. alpha.2 still serves all of
/dist, sothe four SSR checks fail; the SSG block would fail the same way once the SSR
step passes.
Fix
Gate both dist-internals blocks behind
METASSR_DIST_INTERNALS_SINCE(default
1.0.0-alpha.3), the same mechanism already used for per-requestrendering (
METASSR_SSR_PER_REQUEST_SINCE) and TypeScript API routes(
METASSR_TS_API_SINCE). Source builds (METASSR_VERSIONunset) alwaysenforce the assertions; the Docker image skips them until a CLI carrying #249
is published.
tests/web-app/tests/ssr.sh— gate the Dist Internals block.tests/web-app/tests/ssg.sh— gate the SSG Dist Internals block.tests/README.md— document the new cutoff variable.Verification
bash -npasses on both scripts.1.0.0-alpha.2-> skip;1.0.0-alpha.3,1.0.0-alpha.4and unset -> enforce.