Repository navigation
fix(api-handler): ensure deterministic request serialization - #252
Open
Tushar15769 wants to merge 2 commits into
Open
Tushar15769 wants to merge 2 commits into
Tushar15769 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
This fixes Issue #251, where identical API requests could produce different JSON strings because the
query,params, andheadersmaps use Rust'sHashMap, which does not guarantee iteration order.Cause
ApiRequeststoresheaders,params, andqueryasHashMap<String, String>.When
serde_json::to_string(&request)serializes these maps, their keys can appear in different orders even when the request data is identical.This causes different JSON strings for equivalent requests, potentially affecting handlers that rely on request hashing, caching, or idempotency.
Changes
serialize_sorted_maphelper that usesBTreeMapto ensure consistent key ordering during serialization.headers,params, andquery.HashMapfield types and deserialization behavior.Tests
Fixes #251