fix: forward glTF load options from triggers - #1654
Open
ICOM725 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trigger currently drops six glTF options before calling
level.load(). Addscale,rightHanded,lights,lightIntensityScale,castGroundShadowandshadowGroundYto its forwarding list and document them.This uses the explicit-list option from the issue, keeping unknown-setting handling unchanged. The regression tests exercise both direct loading and the fade transition through the real level-loading boundary, including false/zero values and the transition-owned
asyncflag.Type of change
Checklist
pnpm lintpasses)pnpm testpasses)pnpm build)Targeted verification:
pnpm exec vitest run --config packages/melonjs/vitest.config.ts triggerpasses (27 tests). The new forwarding assertions failed before the fix.pnpm lint,pnpm buildandgit diff --checkpass.The full browser suite did not complete on Windows: two Chromium Headless Shell runs stopped with unrelated module-import/iframe errors, and a separate run using installed Chrome stalled in WebGPU specs and was stopped. The full-suite checkbox is intentionally unchecked.
Related issues
Fixes #1649.