Repository navigation
Remove test printbox experimentation, use print-table directly - #137
Merged
Merged
Conversation
The print-table -> printbox translation was an experiment while building
the project; we've since committed to print-table as the primary
rendering path and print-table's own test suite already covers that
translation (including style rendering and the fully-empty-column
drop behavior).
- Delete test__print_table_experimental.ml{,i} and printbox_table.ml{,i}.
- Port the one crs-specific scenario not covered elsewhere (a mostly-empty
Summary_table row) into test__summary_table.ml using plain Print_table.
- Remove printbox, printbox-md, printbox-text, and the now-unused uutf
from dune-project and test/crs/crs-cli/dune.
- Remove the stale Printbox section from NOTICE.md and its vendored
license file.
- Trim dead printbox/uutf spellcheck words from .vscode/settings.json.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
print-table -> printboxtranslation was an experiment while building the project; we've since committed toprint-tableas the primary rendering path. Clean up that part of the repo now.This is motivated now to avoid depending on the internal ast of print-table which is incidentally changing in the next version of the lib upstream.