Skip to content

px4_events: remove cache processing duplication - #2372

Draft
Sean-Hickey1 wants to merge 13 commits into
mavlink:ros2from
AscendEngineering:fix/px4-event-processing-deduplication
Draft

Sean-Hickey1 wants to merge 13 commits into
mavlink:ros2from
AscendEngineering:fix/px4-event-processing-deduplication

Conversation

@Sean-Hickey1

Copy link
Copy Markdown
Contributor

Follow-up to #2370. Opening as a draft while that PR is under review.

Removes duplicate validation on metadata cache hits. Cache loading retains file, size, and header identity checks; acquisition validates the returned content once.

  • Treat invalid cached content as a cache miss and download a replacement without consuming retry budget.
  • Preserve existing validation and retry behavior for downloaded metadata.
  • Leave cache publication, cancellation, and locking unchanged.
  • Update existing tests for valid cache hits, corrupt payloads, malformed metadata, and retry-budget preservation.

Depends on #2370; this branch currently includes its changes. It's own changes are limited to the most recent commit. Opening in Draft so it can start to be reviewed. So far untested on vehicle hardware.

@Sean-Hickey1 Sean-Hickey1 changed the title Fix/px4 event processing deduplication px4_events: Remove cache processing duplication Nov 19, 2026
@Sean-Hickey1 Sean-Hickey1 changed the title px4_events: Remove cache processing duplication px4_events: remove cache processing duplication Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant