Say why the caller grants the permissions [ignore_release] - #142
Merged
Conversation
The comment claimed they are granted here "and not in the called workflow", which is false -- the callee declares them too. What matters is that its declaration can only cap them, never supply them, so the caller's grant is what authorises the dispatch.
AltamashShaikh
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The comment above the caller's
permissions:block said they are granted "here and not in the called workflow". That is not true —plugin-branch-sweep.ymldeclares the same two scopes itself. The load-bearing fact is that its declaration can only cap them, never supply them, so the caller's grant is what makes the dispatch authorised; a reader who followed the comment to the callee found the opposite of what it promised.Caught by a reviewer on the copy of this file added to innocraft/plugin-UsersFlow#138, where it is already corrected. Fixing it here too because this is the file the remaining plugin repositories will be copied from.
Comment-only: the two trailing per-scope comments also go, since they restated what the called workflow already documents.
Issue No
No GitHub issue.
Steps to Replicate the Issue
permissions:in.github/workflows/weekly-branch-sweep.yml.plugin-branch-sweep.yml.Checklist