Skip to content

solution - #1206

Open
Denis-Melnikov-dev wants to merge 4 commits into
mate-academy:masterfrom
Denis-Melnikov-dev:develop
Open

Denis-Melnikov-dev wants to merge 4 commits into
mate-academy:masterfrom
Denis-Melnikov-dev:develop

Conversation

@Denis-Melnikov-dev

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done:

  1. disable auto fill style
Image
  1. after pressing the submit button, the page should not refresh. it should simply clear the inputs

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job you did!

However, the burger-menu button doesn't work on Mobile & Tablet views:

Image

This issue seems to be provoked by non-successful main.js script loading.
However, if we try to open it, there will be no code :(
https://github.com/Denis-Melnikov-dev/layout_dia/blob/develop/src/scripts/main.js

Would you mind to fix it?
Hint: you can easilly make your burger-menu button as <a> link, and simply add href attribute with anchor link (e.g. #menu)

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last fix:
disable page scrolling when the menu is open

Image

@vadiimvooo vadiimvooo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants