Repository navigation
Refactor layers - #904
Merged
Merged
Refactor layers#904
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad MapLibre lifecycle and interaction refactor requires final human review.
Review effort: Lite
Findings: None
What changed in this PR
Refactors MapLibre layer interactions and OSM descriptions while updating MapLibre to 6.11.1.
Changes:
- Centralizes feature selection and OSM description fetching.
- Improves layer lifecycle, overlays, indoor levels, and clustering.
- Updates related tests, assets, imports, and RuboCop configuration.
| File | Description |
|---|---|
vendor/javascript/maplibre-gl-worker.mjs |
Updates MapLibre worker assets. |
spec/features/map_search_spec.rb |
Updates OSM API request stubs. |
config/importmap.rb |
Pins MapLibre 6.11.1. |
app/javascript/maplibre/styles/styles.js |
Prevents duplicate cluster listeners. |
app/javascript/maplibre/layers/wikipedia.js |
Adds layer-owned descriptions and cluster checks. |
app/javascript/maplibre/layers/search.js |
Uses shared OSM element fetching. |
app/javascript/maplibre/layers/raster/raster.js |
Uses centralized feature detection. |
app/javascript/maplibre/layers/overpass/overpass.js |
Uses shared OSM descriptions. |
app/javascript/maplibre/layers/osm.js |
Uses shared OSM utilities. |
app/javascript/maplibre/layers/osm_description.js |
Adds shared OSM fetching and formatting. |
app/javascript/maplibre/layers/layers.js |
Refactors layer and feature lookup. |
app/javascript/maplibre/layers/layer.js |
Centralizes map-wide selection. |
app/javascript/maplibre/layers/indoor/indoor.js |
Stabilizes handlers and level detection. |
app/javascript/maplibre/layers/geojson/levels.js |
Removes an obsolete re-export. |
app/javascript/maplibre/layers/geojson/image_overlays.js |
Tracks overlay sources efficiently. |
app/javascript/maplibre/layers/geojson.js |
Refactors interaction and rendering lifecycle. |
app/javascript/maplibre/layers/basemap.js |
Optimizes feature comparison. |
app/javascript/maplibre/feature/details.js |
Delegates descriptions to layer instances. |
.rubocop.yml |
Merges exclusions and excludes deployment files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.