Repository navigation
Map banners - #897
Merged
Merged
Map banners#897
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical security and clustering issues, plus a moderate scaling issue, block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds configurable description banners for map point features, with banner, square, and bubble styles.
Changes:
- Adds editing controls, persistence, translations, and documentation.
- Renders and synchronizes description banners with GeoJSON features.
- Adds styling, scaling, visibility handling, and feature specs.
| File | Summary |
|---|---|
spec/features/feature_edit_point_spec.rb |
Tests description-banner editing. |
locale/de/app.po |
Adds German translations. |
locale/app.pot |
Updates translation catalog. |
docs/tutorials/geojson_style_spec.md |
Documents show-desc. |
app/views/maps/modals/feature/_edit_ui.haml |
Adds banner-selection controls. |
app/javascript/maplibre/styles/styles.js |
Handles marker scaling and outlines. |
app/javascript/maplibre/map.js |
Integrates visibility and zoom handling. |
app/javascript/maplibre/layers/geojson/desc_banners.js |
Creates and manages description banners. |
app/javascript/maplibre/layers/geojson.js |
Integrates banners with GeoJSON lifecycle. |
app/javascript/maplibre/feature.js |
Synchronizes feature controls. |
app/javascript/controllers/feature/modal_controller.js |
Synchronizes descriptions and controls. |
app/javascript/controllers/feature/edit_controller.js |
Persists selected banner shapes. |
app/assets/stylesheets/map.css |
Styles banner variants and scaling. |
app/assets/stylesheets/feature.css |
Styles feature controls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
digitaltom
force-pushed
the
map_banners
branch
from
September 19, 2026 22:14
c5a7508 to
c315951
Compare
* origin/main: add warning popup for non logged in map owners improve tooltips introduce a 'featured' flag to show maps on frontpage frontpage fixes frontpage work # Conflicts: # locale/app.pot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.