fix(make:layout): use resolvable imports in Layout stub - #332
Merged
Conversation
The scaffolded Layout stub imported outlookFallbackProp and useOutlookFallback via relative paths that only resolve inside the framework's dist/components dir, so a fresh build of a scaffolded layout crashed. Import useOutlookFallback from the public @maizzle/framework entrypoint and inline the outlookFallback prop definition. Closes #331
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesOutlook fallback integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make:layoutscaffolds a stub that imports two framework internals via relative paths:These only resolve from inside
node_modules/@maizzle/framework/dist/components/. The CLI places the file at./componentsby default, so both paths dangle and a freshmaizzle buildcrashes immediately:Fix
useOutlookFallbackfrom the public@maizzle/frameworkentrypoint (it's already exported there).outlookFallbackprop definition intodefineProps().outlookFallbackPropisn't on the public entrypoint, and Vue's<script setup>compiler rejectsdefineProps()referencing a locally-declaredconst, so it has to be inlined.Closes #331
Summary by CodeRabbit