Skip to content

Rfc 1169 route manager drop spike - #9

Merged
BobrImperator merged 3 commits into
rfc-1169-route-managerfrom
rfc-1169-route-manager-drop-spike
Aug 18, 2026
Merged

Rfc 1169 route manager drop spike#9
BobrImperator merged 3 commits into
rfc-1169-route-managerfrom
rfc-1169-route-manager-drop-spike

Conversation

@BobrImperator

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   0.08%↑

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/routing/route-managers/classic/bucket.js 2 kB / 713 B -31%↓1.4 kB / -23.3%↓547 B
./packages/@ember/-internals/routing/route-managers/classic/manager.js 11.7 kB / 3.2 kB -2.02%↓11.4 kB / -1.58%↓3.2 kB
./packages/@ember/-internals/routing/route-managers/classic/outlet-component.js 5 kB / 1.5 kB -9.97%↓4.5 kB / -5.18%↓1.5 kB
./packages/@ember/-internals/routing/route-managers/outlet-state.js 956 B / 407 B
./packages/@ember/-internals/routing/route-managers/root-outlet.js 3.3 kB / 1.1 kB 68%↑5.5 kB / 44%↑1.6 kB
./packages/@ember/routing/router.js 54.9 kB / 12.8 kB -0.32%↓54.7 kB / -0.48%↓12.7 kB
./packages/router_js/index.js 66.2 kB / 14.4 kB 0.2%↑66.3 kB / 0.2%↑14.4 kB
./packages/shared-chunks/template-{hash}.js 1.1 kB / 401 B -54%↓491 B / -49.4%↓203 B
Total (Includes all files) 2.1 MB / 501.6 kB 0.08%↑2.1 MB / 0.1%↑502.2 kB

dist/prod   0.1%↑

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/routing/route-managers/classic/bucket.js 1.9 kB / 655 B -33.8%↓1.2 kB / -25.8%↓486 B
./packages/@ember/-internals/routing/route-managers/classic/manager.js 10.7 kB / 2.9 kB -2.21%↓10.4 kB / -1.66%↓2.8 kB
./packages/@ember/-internals/routing/route-managers/classic/outlet-component.js 4.5 kB / 1.4 kB -8.37%↓4.1 kB / -3.54%↓1.4 kB
./packages/@ember/-internals/routing/route-managers/outlet-state.js 956 B / 407 B
./packages/@ember/-internals/routing/route-managers/root-outlet.js 3.2 kB / 1.1 kB 70%↑5.4 kB / 44%↑1.6 kB
./packages/@ember/routing/router.js 46.2 kB / 11.1 kB 0.2%↑46.3 kB / 0.2%↑11.1 kB
./packages/router_js/index.js 66.2 kB / 14.4 kB 0.2%↑66.3 kB / 0.2%↑14.4 kB
Total (Includes all files) 1.9 MB / 458.4 kB 0.1%↑1.9 MB / 0.1%↑459.1 kB

smoke-tests/v2-app-template/dist   0.2%↑

File Before (Size / Brotli) After (Size / Brotli)
./assets/api-{hash}.js 294.7 kB / 79.4 kB 0.2%↑295.3 kB / 0.1%↑79.5 kB
Total (Includes all files) 346.8 kB / 96.3 kB 0.2%↑347.4 kB / 0.1%↑96.4 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 132.6 kB / 37.1 kB 132.6 kB / 37.1 kB

🤖 This report was automatically generated by wyvox/pkg-size

@BobrImperator
BobrImperator force-pushed the rfc-1169-route-manager-drop-spike branch 4 times, most recently from 12f1aa5 to caed087 Compare August 17, 2026 15:04
// the loading substate.

const invokable = buildClassicInvokable(bucket);
return (enterPromise || Promise.resolve()).then(() => invokable);

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were surprised by it and it was also against the RFC interface.

) {
this.context = routeInfo.context;

routeInfo.enterPromise?.then(

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the only place where we can grab the context without creating more weakmaps while keeping it all in "framework land" without leaking into the route manager

return this.becomeResolved(transition, resolvedContext);
const resolved = this.becomeResolved(transition, resolvedContext);

resolved.invokable = invokable;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't particularily have a strong need for this I believe but the return value was ultimately unused before

@BobrImperator
BobrImperator force-pushed the rfc-1169-route-manager-drop-spike branch 2 times, most recently from caed087 to 4b4408b Compare August 18, 2026 12:15
Subscribes to the enterPromise attached to the routeInfo
@BobrImperator
BobrImperator force-pushed the rfc-1169-route-manager-drop-spike branch from 4b4408b to c1133ea Compare August 18, 2026 12:22
@BobrImperator
BobrImperator marked this pull request as ready for review August 18, 2026 12:24
@BobrImperator
BobrImperator merged commit 0c91449 into rfc-1169-route-manager Aug 18, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant