Rfc 1169 route manager drop spike - #9
Merged
BobrImperator merged 3 commits intoAug 18, 2026
Conversation
📊 Size reportTarball size — dist/dev 0.08%↑
dist/prod 0.1%↑
smoke-tests/v2-app-template/dist 0.2%↑
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
BobrImperator
force-pushed
the
rfc-1169-route-manager-drop-spike
branch
4 times, most recently
from
August 17, 2026 15:04
12f1aa5 to
caed087
Compare
BobrImperator
commented
Aug 17, 2026
| // the loading substate. | ||
|
|
||
| const invokable = buildClassicInvokable(bucket); | ||
| return (enterPromise || Promise.resolve()).then(() => invokable); |
Author
There was a problem hiding this comment.
We were surprised by it and it was also against the RFC interface.
BobrImperator
commented
Aug 17, 2026
| ) { | ||
| this.context = routeInfo.context; | ||
|
|
||
| routeInfo.enterPromise?.then( |
Author
There was a problem hiding this comment.
This is about the only place where we can grab the context without creating more weakmaps while keeping it all in "framework land" without leaking into the route manager
BobrImperator
commented
Aug 17, 2026
| return this.becomeResolved(transition, resolvedContext); | ||
| const resolved = this.becomeResolved(transition, resolvedContext); | ||
|
|
||
| resolved.invokable = invokable; |
Author
There was a problem hiding this comment.
We don't particularily have a strong need for this I believe but the return value was ultimately unused before
BobrImperator
force-pushed
the
rfc-1169-route-manager-drop-spike
branch
2 times, most recently
from
August 18, 2026 12:15
caed087 to
4b4408b
Compare
Subscribes to the enterPromise attached to the routeInfo
BobrImperator
force-pushed
the
rfc-1169-route-manager-drop-spike
branch
from
August 18, 2026 12:22
4b4408b to
c1133ea
Compare
BobrImperator
marked this pull request as ready for review
August 18, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.