Remove on player exit - #332
Open
smallbrownbike wants to merge 3 commits into
Open
Conversation
mafintosh
reviewed
Jun 9, 2018
| process.exit() | ||
| }) | ||
| } | ||
| process.on('SIGINT' || 'SIGTERM', onexit) |
Owner
There was a problem hiding this comment.
this will only listen for sigint :) you need to add both listeners
Owner
|
added minor comment. lgtm otherwise 👍 |
Contributor
|
@smallbrownbike hey, can you? #332 (comment) |
|
Please pardon my ignorance but I'm running peerflix with the following arguments and yet the files are not removed once exiting the player.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #331. --remove now triggers files to be removed when exiting the player.