Conversation
Update astro to 7.0.5: Remove HTML comments inside the communities map expression: Astro 7's. Rust compiler rejects <!-- --> inside JSX expressions.
Convert tuple-form items to list-form so every array element is validated, not just the first. Collapse the three near-identical conference object schemas into one.
blackheaven
approved these changes
Jul 12, 2026
astro check (run by the build job) type-checks test files. Add @types/node for the node: imports and replace test.each with a for...of loop to avoid the vitest tuple typing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette branche fait deux choses : elle migre l'outillage de npm vers pnpm (et bundle les assets front via Astro plutôt que des fichiers vendorisés à la main), puis remplace la validation de schéma Python par un équivalent JS.
Migration npm → pnpm & bundling des assets
package-lock.json, ajout depnpm-lock.yamletpnpm-workspace.yaml.toast-ui/calendar,ical.js,handlebars, etc. ajoutées aupackage.json; suppression des assets vendorisés à la main danspublic/(toastui-calendar.min.css,ical.es5.min.cjs,toastui-calendar.min.js).main.jsdéplacé danssrc/scripts/etmain.cssdanssrc/styles/pour être bundlés. README mis à jour.Layout.astroau lieu de balises statiques.communities/conferences(+ ajustements demain.js).flake.nix(Node), versions dupackage.jsonet du lockfile.Validation de schéma en JS (au lieu de Python)
schema/community.json,schema/conferences.json) : la forme tuple"items": [ … ](qui, en draft-04, ne validait que le premier élément des tableaux) devient la forme liste"items": { … }qui valide tous les éléments. Les 3 objets quasi-identiques deconferences.jsonsont fusionnés en un seul.test/data-schema.test.ts) :ajv(v8) compile les schémas et untest.eachparcourtdata/*.jsonavec le même mapping que l'ancienne CI (conferences.json→ schéma conferences, le reste → community). Messages d'erreur clairs viaajv.errorsText.validatepasse de Python (check-jsonschema) à pnpm/Node +pnpm test. Bonus : les tests unitaires, jamais exécutés en CI jusqu'ici, tournent désormais.