Repository navigation
fix(rust): link self accesses inside macro arguments for LCOM (#177) - #202
Merged
Merged
Conversation
A query anchor skips punctuation, so self.a, (1) in a macro matched as a call to a. Members matches may now capture @arguments, which must be the call name's next sibling. Turbofish calls in macros count as calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tree-sitter-rust parses macro arguments as a flat token tree, so
self.xandself.m()insideformat!,write!,assert!orready!produced no member. Methods lost their LCOM edges, and a method whose only field accesses were inside a macro was excluded as a stub.The Rust Members query now also matches the token sequences
self . x,self . m (…)andSelf :: f (…). The patterns are bare sibling sequences, because a sequence anchored under atoken_treeparent matches only once per tree.The repro in the issue now reports
lcom4: 1.Fixes #177