Repository navigation
feat(config): one .polyscan.toml for every language, with --config - #199
Merged
Merged
Conversation
…ig (#183) polyscan reads the nearest .polyscan.toml at or above the first analyzed path, or the file given with --config/-c on analyze and check. The file sets [analysis] exclude and include_tests, the [complexity] risk thresholds for every language, and the [check] thresholds. A flag takes precedence over the file, and --exclude adds to its patterns. An unknown key or an invalid value fails the run. The jscan configuration files and JSCAN_CONFIG are no longer read. A run that meets one before any .polyscan.toml fails and names the file. The jscan loader, its parsed-but-ignored schema and viper are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183.
.polyscan.tomlat or above the first analyzed path, or the file given with--config/-conanalyzeandcheck.[analysis]setsexcludeandinclude_tests.[complexity]sets the risk thresholds, which now apply to Go, Rust and C++ as well.[check]sets the thresholds ofpolyscan check.--excludeadds to the file's patterns.checkexits 2.jscan.config.json, and theJSCAN_CONFIGvariable are no longer read. A run that reaches one before any.polyscan.tomlfails and names the file. polyscan does not read pyscn's own files and does not treat them as errors.