Repository navigation
fix(polyscan): drop never-populated deps module_metrics fields - #149
Merged
Merged
Conversation
`deps.analysis.module_metrics[*]` serialized `lines_of_code`, `function_count`, `class_count`, `maintainability`, `technical_debt`, `transitive_dependencies` and `package` for every module, and the dependency analyzer filled none of them. Each was emitted as a fixed zero, an empty list or an empty string that a consumer could not tell apart from a measurement. The graph measures none of those, so the fields are removed rather than faked: file sizes are already reported per file in `module_quality`, and `dependency_matrix` carries the full edge set to walk for a module's transitive dependencies. `CalculateTransitiveDependencies`, which only its own test called, goes with them. Claude-Session: https://claude.ai/code/session_01WhKJX9EkCGhPKWBpvjfmXr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144.
deps.analysis.module_metrics[*]serializedlines_of_code,function_count,class_count,maintainability,technical_debt,transitive_dependenciesandpackage, none of which the dependency analyzer ever filled. Every module reported a fixed zero, an empty list or an empty string that a consumer could not tell apart from a measurement.The import graph measures none of those, so the fields are removed rather than filled with numbers borrowed from another analysis. File sizes are reported per file in
module_quality, anddependency_matrixcarries the full edge set to walk for a module's transitive dependencies.CalculateTransitiveDependencies, called only by its own test, is removed too.Docs, CHANGELOG and the
jscan/SYNC.mdnote that recorded the unpopulated fields are updated.schema_versionstays at 1, which has not shipped yet.https://claude.ai/code/session_01WhKJX9EkCGhPKWBpvjfmXr